summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Nick Kralevich <nnk@google.com> 2010-06-09 14:50:10 -0700
committer Android Git Automerger <android-git-automerger@android.com> 2010-06-09 14:50:10 -0700
commit69b04a707513dcb166ed79277e0ae7129d09d4c4 (patch)
tree96d47836fd578adab5d305965a377c1639b6b249
parentf7b79151923ccde24a3c5cb546d9f595f0891f59 (diff)
parent2feafeffb8c2a5e02cb7998194d129ab0f43f9b0 (diff)
am 2feafeff: Merge "Fix a problem with leaking UDP sockets." into kraken
-rw-r--r--services/java/com/android/server/WifiWatchdogService.java7
1 files changed, 6 insertions, 1 deletions
diff --git a/services/java/com/android/server/WifiWatchdogService.java b/services/java/com/android/server/WifiWatchdogService.java
index 87f8a6e69c3f..445dd0366d57 100644
--- a/services/java/com/android/server/WifiWatchdogService.java
+++ b/services/java/com/android/server/WifiWatchdogService.java
@@ -1217,8 +1217,9 @@ public class WifiWatchdogService {
private static Random sRandom = new Random();
static boolean isDnsReachable(int dns, int timeout) {
+ DatagramSocket socket = null;
try {
- DatagramSocket socket = new DatagramSocket();
+ socket = new DatagramSocket();
// Set some socket properties
socket.setSoTimeout(timeout);
@@ -1271,6 +1272,10 @@ public class WifiWatchdogService {
Slog.d(TAG, "DnsPinger.isReachable got an unknown exception", e);
}
return false;
+ } finally {
+ if (socket != null) {
+ socket.close();
+ }
}
}