diff options
| author | 2019-01-10 12:45:49 -0800 | |
|---|---|---|
| committer | 2019-01-10 12:45:49 -0800 | |
| commit | 69139f4cb624d1f9b7302af3fae82865bb65e47c (patch) | |
| tree | 53c61a07c0107314e5eeedee295efef4ae14b83c | |
| parent | c54ffd28f7efa82054ebc4443c7c6a396e07ddd6 (diff) | |
[WPA3] Rename allowedGroupMgmtCiphers to allowedGroupManagementCiphers
Following API Council review:
Rename allowedGroupMgmtCiphers to allowedGroupManagementCiphers in all instances
in order to be consistend with existing members.
Bug: 122616519
Test: atest com.android.server.wifi
Change-Id: I5e24a97308c2c6150ecedbd60ea90c50c20e3760
| -rw-r--r-- | api/current.txt | 2 | ||||
| -rw-r--r-- | wifi/java/android/net/wifi/WifiConfiguration.java | 15 | ||||
| -rw-r--r-- | wifi/java/android/net/wifi/WifiNetworkConfigBuilder.java | 2 | ||||
| -rw-r--r-- | wifi/tests/src/android/net/wifi/WifiNetworkConfigBuilderTest.java | 2 |
4 files changed, 10 insertions, 11 deletions
diff --git a/api/current.txt b/api/current.txt index fad607ccefec..ba2e9cb6c1a3 100644 --- a/api/current.txt +++ b/api/current.txt @@ -29379,7 +29379,7 @@ package android.net.wifi { field public java.lang.String SSID; field public java.util.BitSet allowedAuthAlgorithms; field public java.util.BitSet allowedGroupCiphers; - field public java.util.BitSet allowedGroupMgmtCiphers; + field public java.util.BitSet allowedGroupManagementCiphers; field public java.util.BitSet allowedKeyManagement; field public java.util.BitSet allowedPairwiseCiphers; field public java.util.BitSet allowedProtocols; diff --git a/wifi/java/android/net/wifi/WifiConfiguration.java b/wifi/java/android/net/wifi/WifiConfiguration.java index a809cad74e07..28dd9b471323 100644 --- a/wifi/java/android/net/wifi/WifiConfiguration.java +++ b/wifi/java/android/net/wifi/WifiConfiguration.java @@ -27,7 +27,6 @@ import android.net.NetworkSpecifier; import android.net.ProxyInfo; import android.net.StaticIpConfiguration; import android.net.Uri; -import android.net.wifi.WifiInfo; import android.os.Build; import android.os.Parcel; import android.os.Parcelable; @@ -491,7 +490,7 @@ public class WifiConfiguration implements Parcelable { * The set of group management ciphers supported by this configuration. * See {@link GroupMgmtCipher} for descriptions of the values. */ - public BitSet allowedGroupMgmtCiphers; + public BitSet allowedGroupManagementCiphers; /** * The set of SuiteB ciphers supported by this configuration. * To be used for WPA3-Enterprise mode. @@ -1642,7 +1641,7 @@ public class WifiConfiguration implements Parcelable { allowedAuthAlgorithms = new BitSet(); allowedPairwiseCiphers = new BitSet(); allowedGroupCiphers = new BitSet(); - allowedGroupMgmtCiphers = new BitSet(); + allowedGroupManagementCiphers = new BitSet(); allowedSuiteBCiphers = new BitSet(); wepKeys = new String[4]; for (int i = 0; i < wepKeys.length; i++) { @@ -1835,8 +1834,8 @@ public class WifiConfiguration implements Parcelable { } sbuf.append('\n'); sbuf.append(" GroupMgmtCiphers:"); - for (int gmc = 0; gmc < this.allowedGroupMgmtCiphers.size(); gmc++) { - if (this.allowedGroupMgmtCiphers.get(gmc)) { + for (int gmc = 0; gmc < this.allowedGroupManagementCiphers.size(); gmc++) { + if (this.allowedGroupManagementCiphers.get(gmc)) { sbuf.append(" "); if (gmc < GroupMgmtCipher.strings.length) { sbuf.append(GroupMgmtCipher.strings[gmc]); @@ -2235,7 +2234,7 @@ public class WifiConfiguration implements Parcelable { allowedAuthAlgorithms = (BitSet) source.allowedAuthAlgorithms.clone(); allowedPairwiseCiphers = (BitSet) source.allowedPairwiseCiphers.clone(); allowedGroupCiphers = (BitSet) source.allowedGroupCiphers.clone(); - allowedGroupMgmtCiphers = (BitSet) source.allowedGroupMgmtCiphers.clone(); + allowedGroupManagementCiphers = (BitSet) source.allowedGroupManagementCiphers.clone(); allowedSuiteBCiphers = (BitSet) source.allowedSuiteBCiphers.clone(); enterpriseConfig = new WifiEnterpriseConfig(source.enterpriseConfig); @@ -2317,7 +2316,7 @@ public class WifiConfiguration implements Parcelable { writeBitSet(dest, allowedAuthAlgorithms); writeBitSet(dest, allowedPairwiseCiphers); writeBitSet(dest, allowedGroupCiphers); - writeBitSet(dest, allowedGroupMgmtCiphers); + writeBitSet(dest, allowedGroupManagementCiphers); writeBitSet(dest, allowedSuiteBCiphers); dest.writeParcelable(enterpriseConfig, flags); @@ -2389,7 +2388,7 @@ public class WifiConfiguration implements Parcelable { config.allowedAuthAlgorithms = readBitSet(in); config.allowedPairwiseCiphers = readBitSet(in); config.allowedGroupCiphers = readBitSet(in); - config.allowedGroupMgmtCiphers = readBitSet(in); + config.allowedGroupManagementCiphers = readBitSet(in); config.allowedSuiteBCiphers = readBitSet(in); config.enterpriseConfig = in.readParcelable(null); diff --git a/wifi/java/android/net/wifi/WifiNetworkConfigBuilder.java b/wifi/java/android/net/wifi/WifiNetworkConfigBuilder.java index f73b9e5e2a00..ecee5ff0161d 100644 --- a/wifi/java/android/net/wifi/WifiNetworkConfigBuilder.java +++ b/wifi/java/android/net/wifi/WifiNetworkConfigBuilder.java @@ -412,7 +412,7 @@ public class WifiNetworkConfigBuilder { configuration.allowedKeyManagement.set(WifiConfiguration.KeyMgmt.SUITE_B_192); configuration.allowedGroupCiphers.set(WifiConfiguration.GroupCipher.GCMP_256); // TODO (b/113878056): Verify these params once we verify SuiteB configuration. - configuration.allowedGroupMgmtCiphers.set( + configuration.allowedGroupManagementCiphers.set( WifiConfiguration.GroupMgmtCipher.BIP_GMAC_256); configuration.allowedSuiteBCiphers.set( WifiConfiguration.SuiteBCipher.ECDHE_ECDSA); diff --git a/wifi/tests/src/android/net/wifi/WifiNetworkConfigBuilderTest.java b/wifi/tests/src/android/net/wifi/WifiNetworkConfigBuilderTest.java index 83627ad524d2..dd6e2c9ce7af 100644 --- a/wifi/tests/src/android/net/wifi/WifiNetworkConfigBuilderTest.java +++ b/wifi/tests/src/android/net/wifi/WifiNetworkConfigBuilderTest.java @@ -518,7 +518,7 @@ public class WifiNetworkConfigBuilderTest { .get(WifiConfiguration.KeyMgmt.SUITE_B_192)); assertTrue(suggestion.wifiConfiguration.allowedGroupCiphers .get(WifiConfiguration.GroupCipher.GCMP_256)); - assertTrue(suggestion.wifiConfiguration.allowedGroupMgmtCiphers + assertTrue(suggestion.wifiConfiguration.allowedGroupManagementCiphers .get(WifiConfiguration.GroupMgmtCipher.BIP_GMAC_256)); assertTrue(suggestion.wifiConfiguration.allowedSuiteBCiphers .get(WifiConfiguration.SuiteBCipher.ECDHE_ECDSA)); |