summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Dianne Hackborn <hackbod@android.com> 2011-07-25 17:25:09 -0700
committer Android Git Automerger <android-git-automerger@android.com> 2011-07-25 17:25:09 -0700
commit68454aa049b3dbadc60662e82c4c931fc970c20e (patch)
tree3cf1ddc77fc2e5215654d306afad0686ed3b8e6a
parentb4913b8754653d0c9b3bdb88a0e4d971d9830c69 (diff)
parent1b20abd30c2757132b7a2d319ae73f420b864ed4 (diff)
am 1b20abd3: am 20bf46af: am b0878223: am 6800a801: Merge "frameworks/base: Cap the number of toasts that a package can post."
* commit '1b20abd30c2757132b7a2d319ae73f420b864ed4': frameworks/base: Cap the number of toasts that a package can post.
-rwxr-xr-xservices/java/com/android/server/NotificationManagerService.java18
1 files changed, 18 insertions, 0 deletions
diff --git a/services/java/com/android/server/NotificationManagerService.java b/services/java/com/android/server/NotificationManagerService.java
index 5d7a48f491f4..8031c4e1f53e 100755
--- a/services/java/com/android/server/NotificationManagerService.java
+++ b/services/java/com/android/server/NotificationManagerService.java
@@ -469,6 +469,24 @@ public class NotificationManagerService extends INotificationManager.Stub
record = mToastQueue.get(index);
record.update(duration);
} else {
+ // Limit the number of toasts that any given package except the android
+ // package can enqueue. Prevents DOS attacks and deals with leaks.
+ if (!"android".equals(pkg)) {
+ int count = 0;
+ final int N = mToastQueue.size();
+ for (int i=0; i<N; i++) {
+ final ToastRecord r = mToastQueue.get(i);
+ if (r.pkg.equals(pkg)) {
+ count++;
+ if (count >= MAX_PACKAGE_NOTIFICATIONS) {
+ Slog.e(TAG, "Package has already posted " + count
+ + " toasts. Not showing more. Package=" + pkg);
+ return;
+ }
+ }
+ }
+ }
+
record = new ToastRecord(callingPid, pkg, callback, duration);
mToastQueue.add(record);
index = mToastQueue.size() - 1;