summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <treehugger-gerrit@google.com> 2018-12-21 05:53:36 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2018-12-21 05:53:36 +0000
commit667dba5c14a9359c13116d31a51409c8bf05bdad (patch)
tree62e65d08df11bc315887aca66117a61421d1e2ac
parent138aae8eaf404bcda3673e65f29c813909093c84 (diff)
parent81aff0fbabf72354f635b07c714d5dedaa9a1419 (diff)
Merge "Fix/suppress startop google-explicit-constructor warnings"
-rw-r--r--startop/view_compiler/dex_builder.h4
-rw-r--r--startop/view_compiler/main.cc2
2 files changed, 3 insertions, 3 deletions
diff --git a/startop/view_compiler/dex_builder.h b/startop/view_compiler/dex_builder.h
index 06059c8c6e56..757d863461f0 100644
--- a/startop/view_compiler/dex_builder.h
+++ b/startop/view_compiler/dex_builder.h
@@ -73,7 +73,7 @@ class TypeDescriptor {
bool operator<(const TypeDescriptor& rhs) const { return descriptor_ < rhs.descriptor_; }
private:
- TypeDescriptor(std::string descriptor) : descriptor_{descriptor} {}
+ explicit TypeDescriptor(std::string descriptor) : descriptor_{descriptor} {}
const std::string descriptor_;
};
@@ -83,7 +83,7 @@ class TypeDescriptor {
class Prototype {
public:
template <typename... TypeDescriptors>
- Prototype(TypeDescriptor return_type, TypeDescriptors... param_types)
+ explicit Prototype(TypeDescriptor return_type, TypeDescriptors... param_types)
: return_type_{return_type}, param_types_{param_types...} {}
// Encode this prototype into the dex file.
diff --git a/startop/view_compiler/main.cc b/startop/view_compiler/main.cc
index 9351dc34ea54..55bfdc78ec1b 100644
--- a/startop/view_compiler/main.cc
+++ b/startop/view_compiler/main.cc
@@ -42,7 +42,7 @@ DEFINE_string(package, "", "The package name for the generated class (required)"
class ViewCompilerXmlVisitor : public XMLVisitor {
public:
- ViewCompilerXmlVisitor(JavaLangViewBuilder* builder) : builder_(builder) {}
+ explicit ViewCompilerXmlVisitor(JavaLangViewBuilder* builder) : builder_(builder) {}
bool VisitEnter(const XMLDocument& /*doc*/) override {
builder_->Start();