summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Tony Mak <tonymak@google.com> 2019-11-27 12:09:02 -0800
committer android-build-merger <android-build-merger@google.com> 2019-11-27 12:09:02 -0800
commit64bf5c622161e9a033ac4428ac6e295bd14fb7c7 (patch)
tree9113233b9defde7c991988742a64e233671187fb
parentbdf17fb2b3e46757b674ee9eaabd1c36aeffeb46 (diff)
parent47cb8217b1d7d172e807f2e868c3c6beeeb4b3af (diff)
Merge "Fix a broken test by mocking PackageManager" am: 9301bbf008
am: 47cb8217b1 Change-Id: I14f83f5f0891cc437a04306da1c51aaa0e096713
-rw-r--r--core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java9
-rw-r--r--services/accessibility/TEST_MAPPING6
2 files changed, 6 insertions, 9 deletions
diff --git a/core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java b/core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java
index c2fa8b2b38da..a9a9550d7909 100644
--- a/core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java
+++ b/core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java
@@ -529,8 +529,10 @@ public class TextClassifierTest {
}
@Test
- public void testSuggetsConversationActions_deduplicate() {
- if (isTextClassifierDisabled()) return;
+ public void testSuggestConversationActions_deduplicate() {
+ Context context = new FakeContextBuilder()
+ .setIntentComponent(Intent.ACTION_SENDTO, FakeContextBuilder.DEFAULT_COMPONENT)
+ .build();
ConversationActions.Message message =
new ConversationActions.Message.Builder(
ConversationActions.Message.PERSON_USER_OTHERS)
@@ -541,7 +543,8 @@ public class TextClassifierTest {
.setMaxSuggestions(3)
.build();
- ConversationActions conversationActions = mClassifier.suggestConversationActions(request);
+ TextClassifier classifier = new TextClassifierImpl(context, TC_CONSTANTS);
+ ConversationActions conversationActions = classifier.suggestConversationActions(request);
Truth.assertThat(conversationActions.getConversationActions()).isEmpty();
}
diff --git a/services/accessibility/TEST_MAPPING b/services/accessibility/TEST_MAPPING
index 45c52452afb4..d90c3bd9b4c2 100644
--- a/services/accessibility/TEST_MAPPING
+++ b/services/accessibility/TEST_MAPPING
@@ -52,9 +52,6 @@
},
{
"exclude-annotation": "androidx.test.filters.FlakyTest"
- },
- {
- "exclude-filter": "android.view.textclassifier.TextClassifierTest#testSuggetsConversationActions_deduplicate"
}
]
},
@@ -66,9 +63,6 @@
},
{
"exclude-annotation": "androidx.test.filters.FlakyTest"
- },
- {
- "exclude-filter": "android.view.textclassifier.TextClassifierTest#testSuggetsConversationActions_deduplicate"
}
]
}