diff options
| author | 2024-10-02 13:57:33 +0000 | |
|---|---|---|
| committer | 2024-10-02 14:16:25 +0000 | |
| commit | 63595e7b8bda119f7a4c3687e47a7feb7e5ca705 (patch) | |
| tree | e4d417d8bd95dbe3982015bbdd76fece7684fd4e | |
| parent | 9293f4930bf992d68cc0af4d265aa980e73f7e12 (diff) | |
Revert^2 "[Autofill] : Fix save regression with relayout"
Revert submission 29670006-revert-29642666-enable_relayout-fix-XRQUPKOIQT
Reason for revert: Reason for revert: Fix forward the breaking CTS change.
Previous ABTD run showed only 2 errors
(https://android-build.corp.google.com/test_investigate/invocation/I72700010321346725/test/TR38029463173765066/?redirect=http%3A%2F%2Ffusion2%2Fbf519ddf-848f-4cdd-ac31-7945fc793925),
which were addressed.
However, what was missed was that the suite skipped over many tests,
one of which was the failing test. Re-running the whole suite
Reverted changes: /q/submissionid:29670006-revert-29642666-enable_relayout-fix-XRQUPKOIQT
Bug: 369882186
Test: atest android.autofillservice.cts.dropdown.AuthenticationTest#testDatasetAuthThenModifyAndSaveOnViewsInvisible
Run the following test with the following setup
adb shell device_config put autofill enable_relayout true;
adb shell device_config put autofill enable_relative_location_for_relayout false;
This test fails without the changes in this topic, but passes with them.
Flag: EXEMPT : DeviceConfig flags used: enable_relayout
Reverted changes: /q/submissionid:29670006-revert-29642666-enable_relayout-fix-XRQUPKOIQT
9293f4930bf992d68cc0af4d265aa980e73f7e12
Change-Id: Ibc7fe9cc69d2f1fa67b67ae4511f37a1192e5526
| -rw-r--r-- | core/java/android/view/autofill/AutofillStateFingerprint.java | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/core/java/android/view/autofill/AutofillStateFingerprint.java b/core/java/android/view/autofill/AutofillStateFingerprint.java index 2db4285f0820..7f3858e842ed 100644 --- a/core/java/android/view/autofill/AutofillStateFingerprint.java +++ b/core/java/android/view/autofill/AutofillStateFingerprint.java @@ -97,7 +97,6 @@ public final class AutofillStateFingerprint { if (sDebug) { Log.d(TAG, "Autofillable views count prior to auth:" + autofillableViews.size()); } -// ArrayList<Integer> hashes = getFingerprintIds(autofillableViews); ArrayMap<Integer, View> hashes = getFingerprintIds(autofillableViews); for (Map.Entry<Integer, View> entry : hashes.entrySet()) { @@ -123,7 +122,6 @@ public final class AutofillStateFingerprint { if (view != null) { int id = getEphemeralFingerprintId(view, 0 /* position irrelevant */); AutofillId autofillId = view.getAutofillId(); - autofillId.setSessionId(mSessionId); mHashToAutofillIdMap.put(id, autofillId); } else { if (sDebug) { |