summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Adrian Roos <roosa@google.com> 2019-02-28 02:28:53 -0800
committer android-build-merger <android-build-merger@google.com> 2019-02-28 02:28:53 -0800
commit606210ec8b7f60d332da7b43450cdba2b8765b83 (patch)
treee9f4f3cd847e0aee10f56976cd6e2176fb8df508
parent82fd15cbaae90b1779f79ac4ff4b6d300a73e421 (diff)
parent77864f7dac511626a197bf2592470aaed5ef3d35 (diff)
Merge "Apilint: Enforce final builders" am: 2886d307bd am: bb74d55781
am: 77864f7dac Change-Id: I9e3684b3a4548350e006b27f5d13f8fafb766075
-rw-r--r--tools/apilint/apilint.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py
index 4c02d94542d0..ef405e4b1343 100644
--- a/tools/apilint/apilint.py
+++ b/tools/apilint/apilint.py
@@ -1109,6 +1109,9 @@ def verify_builder(clazz):
if not has_build:
warn(clazz, None, None, "Missing build() method")
+ if "final" not in clazz.split:
+ error(clazz, None, None, "Builder should be final")
+
def verify_aidl(clazz):
"""Catch people exposing raw AIDL."""