diff options
| author | 2020-04-07 21:13:41 -0700 | |
|---|---|---|
| committer | 2020-04-07 21:13:41 -0700 | |
| commit | 5f9e3a0dc6566f6270005ffc3c9b5477121f2ca2 (patch) | |
| tree | ea5d67528228b43717408f1fabb6c94f441fd746 | |
| parent | f41567922839d9e84fad0333788301b6c2b330de (diff) | |
Uninitialized member fix :(
Bug: b/153468113
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ida26dc1476c2b329f9aba4d605e65c43e2cafac2
| -rw-r--r-- | services/incremental/IncrementalService.cpp | 1 | ||||
| -rw-r--r-- | services/incremental/IncrementalService.h | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/services/incremental/IncrementalService.cpp b/services/incremental/IncrementalService.cpp index d6ce529fb56f..bca21cd66117 100644 --- a/services/incremental/IncrementalService.cpp +++ b/services/incremental/IncrementalService.cpp @@ -578,6 +578,7 @@ StorageId IncrementalService::findStorageId(std::string_view path) const { int IncrementalService::setStorageParams(StorageId storageId, bool enableReadLogs) { const auto ifs = getIfs(storageId); if (!ifs) { + LOG(ERROR) << "setStorageParams failed, invalid storageId: " << storageId; return -EINVAL; } diff --git a/services/incremental/IncrementalService.h b/services/incremental/IncrementalService.h index c2a550b62438..0843fde918e9 100644 --- a/services/incremental/IncrementalService.h +++ b/services/incremental/IncrementalService.h @@ -160,12 +160,12 @@ public: class IncrementalServiceConnector : public BnIncrementalServiceConnector { public: IncrementalServiceConnector(IncrementalService& incrementalService, int32_t storage) - : incrementalService(incrementalService) {} + : incrementalService(incrementalService), storage(storage) {} binder::Status setStorageParams(bool enableReadLogs, int32_t* _aidl_return) final; private: IncrementalService& incrementalService; - int32_t storage; + int32_t const storage; }; private: |