summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Caitlin Shkuratov <caitlinshk@google.com> 2025-03-18 11:50:56 -0700
committer Android (Google) Code Review <android-gerrit@google.com> 2025-03-18 11:50:56 -0700
commit5bbdd77b1b6f6a3187a15f159d7ea00671b5e461 (patch)
tree9e2cdc8c6b31e438fe09ae8af75963e512eabe0e
parent54c519481a3781a6125987bfe1031692b84f7714 (diff)
parent028948f00cb9d138987cd1e49a5e12d69b3d68ba (diff)
Merge "[SB] Small cleanups of EndMediaProjectionDialogHelper" into main
-rw-r--r--packages/SystemUI/src/com/android/systemui/statusbar/chips/mediaprojection/ui/view/EndMediaProjectionDialogHelper.kt16
1 files changed, 11 insertions, 5 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/chips/mediaprojection/ui/view/EndMediaProjectionDialogHelper.kt b/packages/SystemUI/src/com/android/systemui/statusbar/chips/mediaprojection/ui/view/EndMediaProjectionDialogHelper.kt
index 2d9ccb7b09b0..33ff6c014125 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/chips/mediaprojection/ui/view/EndMediaProjectionDialogHelper.kt
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/chips/mediaprojection/ui/view/EndMediaProjectionDialogHelper.kt
@@ -19,6 +19,7 @@ package com.android.systemui.statusbar.chips.mediaprojection.ui.view
import android.app.ActivityManager
import android.content.DialogInterface
import android.content.pm.PackageManager
+import android.util.Log
import com.android.systemui.animation.DialogTransitionAnimator
import com.android.systemui.dagger.SysUISingleton
import com.android.systemui.mediaprojection.data.model.MediaProjectionState
@@ -54,10 +55,6 @@ constructor(
// dialog to animate back into the chip just for the chip to disappear in a few frames.
dialogTransitionAnimator.disableAllCurrentDialogsExitAnimations()
stopAction.invoke()
- // TODO(b/332662551): If the projection is stopped, there's a brief moment where the
- // dialog closes and the chip re-shows because the system APIs haven't come back and
- // told SysUI that the projection has officially stopped. It would be great for the chip
- // to not re-show at all.
}
}
@@ -85,8 +82,17 @@ constructor(
val appInfo = packageManager.getApplicationInfo(packageName, 0)
appInfo.loadLabel(packageManager)
} catch (e: PackageManager.NameNotFoundException) {
- // TODO(b/332662551): Log this error.
+ Log.w(
+ TAG,
+ "Failed to find application info for package: $packageName when creating " +
+ "end media projection dialog",
+ e,
+ )
null
}
}
+
+ companion object {
+ private const val TAG = "EndMediaProjectionDialogHelper"
+ }
}