summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Keith Mok <keithmok@google.com> 2021-11-12 23:55:16 +0000
committer Keith Mok <keithmok@google.com> 2021-11-13 00:33:31 +0000
commit57e0882c77f575b0344074727e8a44a1fe015741 (patch)
tree642164b9ae6cfc3936304814c060b9a8adc9ca59
parenta8c0faa12041eddf2c99e3f8e2bee7056a9af1a8 (diff)
Fix EINTR handling
The return value of read will not be errno directly. Fix it and use TEMP_FAILURE_RETRY for read/write Test: Builds OK Change-Id: Ic128156f881e2ce4609d9a66269405272291fbdc
-rw-r--r--media/native/midi/amidi.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/media/native/midi/amidi.cpp b/media/native/midi/amidi.cpp
index 923377c8180e..f90796e415c0 100644
--- a/media/native/midi/amidi.cpp
+++ b/media/native/midi/amidi.cpp
@@ -325,8 +325,8 @@ public:
}
uint8_t readBuffer[AMIDI_PACKET_SIZE];
- ssize_t readCount = read(mPort->ufd, readBuffer, sizeof(readBuffer));
- if (readCount == EINTR || readCount < 1) {
+ ssize_t readCount = TEMP_FAILURE_RETRY(read(mPort->ufd, readBuffer, sizeof(readBuffer)));
+ if (readCount < 1) {
return AMEDIA_ERROR_UNKNOWN;
}
@@ -407,7 +407,8 @@ ssize_t AMIDI_API AMidiInputPort_sendWithTimestamp(const AMidiInputPort *inputPo
ssize_t numTransferBytes =
AMIDI_makeSendBuffer(writeBuffer, data + numSent, blockSize, timestamp);
- ssize_t numWritten = write(((AMIDI_Port*)inputPort)->ufd, writeBuffer, numTransferBytes);
+ ssize_t numWritten = TEMP_FAILURE_RETRY(write(((AMIDI_Port*)inputPort)->ufd, writeBuffer,
+ numTransferBytes));
if (numWritten < 0) {
break; // error so bail out.
}
@@ -430,7 +431,8 @@ media_status_t AMIDI_API AMidiInputPort_sendFlush(const AMidiInputPort *inputPor
uint8_t opCode = AMIDI_OPCODE_FLUSH;
ssize_t numTransferBytes = 1;
- ssize_t numWritten = write(((AMIDI_Port*)inputPort)->ufd, &opCode, numTransferBytes);
+ ssize_t numWritten = TEMP_FAILURE_RETRY(write(((AMIDI_Port*)inputPort)->ufd, &opCode,
+ numTransferBytes));
if (numWritten < numTransferBytes) {
ALOGE("AMidiInputPort_flush Couldn't write MIDI flush. requested:%zd, written:%zd",