diff options
| author | 2023-09-14 18:57:17 +0000 | |
|---|---|---|
| committer | 2023-09-18 15:23:23 +0000 | |
| commit | 55ac6cbaf0e99e5c9ddcd5bc73775b6eeefb59d2 (patch) | |
| tree | 0f368f9858ea1db7b9ec6f9e47e0eb0191da12b0 | |
| parent | 6222073c1e9287359a4136d6a516769774003685 (diff) | |
Fixes dark-text-dark-background on A11yMenu grid items.
Screenshots:
- Light mode: https://screenshot.googleplex.com/BBjAK3rW3QRaZnj.png
- Dark mode: https://screenshot.googleplex.com/83x8x4VEuc2spXM.png
Flag: RESOURCES_ONLY
Test: launch menu in light & dark mode, observe text is
white-on-black or black-on-white.
Change-Id: I545cdb7acbcba99bd719dc376ab48482fc022a88
3 files changed, 4 insertions, 2 deletions
diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/layout/grid_item.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/layout/grid_item.xml index 587395d4f636..fd9a9c634a36 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/layout/grid_item.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/layout/grid_item.xml @@ -15,7 +15,7 @@ android:layout_centerHorizontal="true" android:scaleType="fitCenter"/> -<TextView + <TextView android:id="@+id/shortcutLabel" android:layout_width="match_parent" android:layout_height="wrap_content" @@ -27,6 +27,6 @@ android:lines="2" android:textSize="@dimen/label_text_size" android:textAlignment="center" - android:textAppearance="@android:style/TextAppearance.DeviceDefault.Widget.Button"/> + android:textColor="@color/grid_item_text_color"/> </RelativeLayout> diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml index fbf2b071ea3c..f961bdbac0aa 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml @@ -20,5 +20,6 @@ <color name="footer_icon_disabled_color">#5F6368</color> <color name="colorControlNormal">#202124</color> <color name="snackbar_bg_color">@android:color/white</color> + <color name="grid_item_text_color">@android:color/white</color> </resources> diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml index d81d0d511a87..9722eb04130f 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml @@ -21,6 +21,7 @@ <color name="footer_icon_disabled_color">#ddd</color> <color name="colorControlNormal">@android:color/white</color> <color name="snackbar_bg_color">#313235</color> + <color name="grid_item_text_color">@android:color/black</color> <color name="colorAccessibilityMenuIcon">#3AA757</color> </resources> |