summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Julia Reynolds <juliacr@google.com> 2020-10-23 14:04:04 -0400
committer Julia Reynolds <juliacr@google.com> 2020-10-23 14:06:49 -0400
commit54f0682ff06235a02d01c7af521419f3aa78b93b (patch)
tree4f9739012c90737b2f28f397af2b27b832546387
parent617a0256ad5f1c55c5b9fd1c9d9ca9cffd5ae55a (diff)
Temporarily disable some Bubbles checks
Test: atest Bug: 171418004 Change-Id: I11517d35594901108789621218457b3221ecaf1d
-rwxr-xr-xservices/core/java/com/android/server/notification/NotificationManagerService.java5
-rwxr-xr-xservices/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java5
2 files changed, 6 insertions, 4 deletions
diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java
index 4d6b760fc56f..0a11fbc2d12c 100755
--- a/services/core/java/com/android/server/notification/NotificationManagerService.java
+++ b/services/core/java/com/android/server/notification/NotificationManagerService.java
@@ -6091,14 +6091,15 @@ public class NotificationManagerService extends SystemService {
}
// bubble or inline reply that's immutable?
- if (n.getBubbleMetadata() != null
+ // TODO (b/171418004): renable after app outreach
+ /*if (n.getBubbleMetadata() != null
&& n.getBubbleMetadata().getIntent() != null
&& hasFlag(mAmi.getPendingIntentFlags(
n.getBubbleMetadata().getIntent().getTarget()),
PendingIntent.FLAG_IMMUTABLE)) {
throw new IllegalArgumentException(r.getKey() + " Not posted."
+ " PendingIntents attached to bubbles must be mutable");
- }
+ }*/
if (n.actions != null) {
for (Notification.Action action : n.actions) {
diff --git a/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java b/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java
index 1100496dffbe..5016710f22b9 100755
--- a/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java
+++ b/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java
@@ -7145,7 +7145,8 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
inOrder.verify(child).recordDismissalSentiment(anyInt());
}
- @Test
+ // TODO (b/171418004): renable after app outreach
+ /*@Test
public void testImmutableBubbleIntent() throws Exception {
when(mAmi.getPendingIntentFlags(pi1))
.thenReturn(FLAG_IMMUTABLE | FLAG_ONE_SHOT);
@@ -7160,7 +7161,7 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
} catch (IllegalArgumentException e) {
// good
}
- }
+ }*/
@Test
public void testMutableBubbleIntent() throws Exception {