summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Anthony Han <modan@google.com> 2019-06-26 16:01:18 -0700
committer Anthony Han <modan@google.com> 2019-07-19 13:10:05 -0700
commit54d2d76ad72a437ba6296fa9cb0a609b9822e776 (patch)
tree9476ff4a1220bf03112530d8595fc160cfd4b616
parent8ae8ca4d8537b06262d36e6fc25fbd9d71f57a25 (diff)
Fix comments in DisplayWhiteBalanceController
Test: build Change-Id: I90c9d95913b4adb5c12807b5670228102799280d
-rw-r--r--services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java20
1 files changed, 14 insertions, 6 deletions
diff --git a/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java b/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java
index 02ec10e2d49d..1cd0f82312cc 100644
--- a/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java
+++ b/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java
@@ -63,7 +63,13 @@ public class DisplayWhiteBalanceController implements
AmbientFilter mColorTemperatureFilter;
private DisplayWhiteBalanceThrottler mThrottler;
+ // In low brightness conditions the ALS readings are more noisy and produce
+ // high errors. This default is introduced to provide a fixed display color
+ // temperature when sensor readings become unreliable.
private final float mLowLightAmbientColorTemperature;
+ // In high brightness conditions certain color temperatures can cause peak display
+ // brightness to drop. This fixed color temperature can be used to compensate for
+ // this effect.
private final float mHighLightAmbientColorTemperature;
private float mAmbientColorTemperature;
@@ -84,12 +90,14 @@ public class DisplayWhiteBalanceController implements
// A piecewise linear relationship between ambient and display color temperatures.
private Spline.LinearSpline mAmbientToDisplayColorTemperatureSpline;
- // In very low or very high brightness conditions ambient EQ should to set to a default
- // instead of using mAmbientToDisplayColorTemperatureSpline. However, setting ambient EQ
- // based on thresholds can cause the display to rapidly change color temperature. To solve
- // this, mLowLightAmbientBrightnessToBiasSpline and mHighLightAmbientBrightnessToBiasSpline
- // are used to smoothly interpolate from ambient color temperature to the defaults.
- // A piecewise linear relationship between low light brightness and low light bias.
+ // In very low or very high brightness conditions Display White Balance should
+ // be to set to a default instead of using mAmbientToDisplayColorTemperatureSpline.
+ // However, setting Display White Balance based on thresholds can cause the
+ // display to rapidly change color temperature. To solve this,
+ // mLowLightAmbientBrightnessToBiasSpline and
+ // mHighLightAmbientBrightnessToBiasSpline are used to smoothly interpolate from
+ // ambient color temperature to the defaults. A piecewise linear relationship
+ // between low light brightness and low light bias.
private Spline.LinearSpline mLowLightAmbientBrightnessToBiasSpline;
// A piecewise linear relationship between high light brightness and high light bias.