summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Kai Peng <justkoomega@gmail.com> 2022-04-11 12:41:37 +0000
committer Kai Peng <justkoomega@gmail.com> 2022-04-11 12:41:44 +0000
commit546fbc8bf7b385e01ad1efbdfb41cb604f26d148 (patch)
treea1285e062e0f613ad9535da104b9ac4a4ae30f08
parentf743f382c9385c979a29f3033b0b01aa8ed86a9b (diff)
Bad lock object.
Locking on an interned string can cause unexpected locking collisions, and we should lock the mLock object here. Change-Id: I8b6557371b0cb79e1bcbc732982cf66b9de663a5
-rw-r--r--services/core/java/com/android/server/clipboard/ClipboardService.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/clipboard/ClipboardService.java b/services/core/java/com/android/server/clipboard/ClipboardService.java
index a0c5aa364f0d..863be98606f0 100644
--- a/services/core/java/com/android/server/clipboard/ClipboardService.java
+++ b/services/core/java/com/android/server/clipboard/ClipboardService.java
@@ -582,7 +582,7 @@ public class ClipboardService extends SystemService {
void setPrimaryClipInternal(PerUserClipboard clipboard, @Nullable ClipData clip,
int uid) {
- synchronized ("mLock") {
+ synchronized (mLock) {
setPrimaryClipInternalLocked(clipboard, clip, uid, null);
}
}