diff options
| author | 2017-04-07 15:59:12 +0000 | |
|---|---|---|
| committer | 2017-04-07 15:59:17 +0000 | |
| commit | 5393a0e2d99f323759d7abc56577e1d3004b51d0 (patch) | |
| tree | 6ead6959f0192a23756aa1e861163f6258a4387d | |
| parent | 31fcda576f4302869b3140a77ee75a0a0d44bd75 (diff) | |
| parent | aca84c0b2a27e921cc6a77ee61ebad218ac1b4f6 (diff) | |
Merge changes If96c0146,I0d68ad60 into oc-dev
* changes:
Improved accessibility behavior of the notification shelf
Fixed a bug where the indeterminate progressbar janky
4 files changed, 16 insertions, 4 deletions
diff --git a/core/java/android/app/Notification.java b/core/java/android/app/Notification.java index 6d7486b5311e..7f26f4fd7050 100644 --- a/core/java/android/app/Notification.java +++ b/core/java/android/app/Notification.java @@ -3667,7 +3667,6 @@ public class Notification implements Parcelable contentView.setTextViewText(R.id.text, null); contentView.setViewVisibility(R.id.text_line_1, View.GONE); contentView.setTextViewText(R.id.text_line_1, null); - contentView.setViewVisibility(R.id.progress, View.GONE); } /** diff --git a/packages/SystemUI/res/layout/status_bar_notification_shelf.xml b/packages/SystemUI/res/layout/status_bar_notification_shelf.xml index 6db16fec5428..7bfbd3c542e1 100644 --- a/packages/SystemUI/res/layout/status_bar_notification_shelf.xml +++ b/packages/SystemUI/res/layout/status_bar_notification_shelf.xml @@ -19,7 +19,6 @@ xmlns:android="http://schemas.android.com/apk/res/android" android:layout_width="match_parent" android:layout_height="@dimen/notification_shelf_height" - android:contentDescription="@string/notification_shelf_content_description" android:focusable="true" android:clickable="true" > diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index 43aeaa3c9314..7bd9526cb274 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -412,7 +412,7 @@ <string name="accessibility_notifications_button">Notifications.</string> <!-- Content description of overflow icon container of the notifications for accessibility (not shown on the screen)[CHAR LIMIT=NONE] --> - <string name="notification_shelf_content_description">Notification overflow container</string> + <string name="accessibility_overflow_action">See all notifications</string> <!-- Content description of the button for removing a notification in the notification panel for accessibility (not shown on the screen). [CHAR LIMIT=NONE] --> <string name="accessibility_remove_notification">Clear notification.</string> diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelf.java b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelf.java index 715dc82d1a1f..51345c20abe1 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelf.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationShelf.java @@ -22,6 +22,7 @@ import android.os.SystemProperties; import android.util.AttributeSet; import android.view.View; import android.view.ViewGroup; +import android.view.accessibility.AccessibilityNodeInfo; import com.android.systemui.Interpolators; import com.android.systemui.R; @@ -577,7 +578,7 @@ public class NotificationShelf extends ActivatableNotificationView implements setClickable(mInteractive); setFocusable(mInteractive); setImportantForAccessibility(mInteractive ? View.IMPORTANT_FOR_ACCESSIBILITY_YES - : View.IMPORTANT_FOR_ACCESSIBILITY_NO); + : View.IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS); } @Override @@ -604,6 +605,19 @@ public class NotificationShelf extends ActivatableNotificationView implements } @Override + public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) { + super.onInitializeAccessibilityNodeInfo(info); + if (mInteractive) { + info.addAction(AccessibilityNodeInfo.AccessibilityAction.ACTION_EXPAND); + AccessibilityNodeInfo.AccessibilityAction unlock + = new AccessibilityNodeInfo.AccessibilityAction( + AccessibilityNodeInfo.ACTION_CLICK, + getContext().getString(R.string.accessibility_overflow_action)); + info.addAction(unlock); + } + } + + @Override public void onLayoutChange(View v, int left, int top, int right, int bottom, int oldLeft, int oldTop, int oldRight, int oldBottom) { updateRelativeOffset(); |