diff options
| author | 2012-01-05 14:11:40 -0800 | |
|---|---|---|
| committer | 2012-01-05 14:11:40 -0800 | |
| commit | 4b4d00e7149f11c84614d8cc98ae7bff21dbd960 (patch) | |
| tree | 714ffc2f580ca3d33ef0502bac624bdba812b529 | |
| parent | bd47cac4dfc8440a848b33107cba1d6773f3e124 (diff) | |
| parent | 399381868992c68abefa5dde62bfdc0a7e33e5e5 (diff) | |
Merge "ThumbnailUtils: To fix misuse of FileInputStream."
| -rw-r--r-- | media/java/android/media/ThumbnailUtils.java | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/media/java/android/media/ThumbnailUtils.java b/media/java/android/media/ThumbnailUtils.java index b320515dfbac..8eb933247472 100644 --- a/media/java/android/media/ThumbnailUtils.java +++ b/media/java/android/media/ThumbnailUtils.java @@ -104,8 +104,10 @@ public class ThumbnailUtils { } if (bitmap == null) { + FileInputStream stream = null; try { - FileDescriptor fd = new FileInputStream(filePath).getFD(); + stream = new FileInputStream(filePath); + FileDescriptor fd = stream.getFD(); BitmapFactory.Options options = new BitmapFactory.Options(); options.inSampleSize = 1; options.inJustDecodeBounds = true; @@ -125,7 +127,16 @@ public class ThumbnailUtils { Log.e(TAG, "", ex); } catch (OutOfMemoryError oom) { Log.e(TAG, "Unable to decode file " + filePath + ". OutOfMemoryError.", oom); + } finally { + try { + if (stream != null) { + stream.close(); + } + } catch (IOException ex) { + Log.e(TAG, "", ex); + } } + } if (kind == Images.Thumbnails.MICRO_KIND) { |