diff options
| author | 2022-11-09 21:39:39 +0000 | |
|---|---|---|
| committer | 2022-11-09 21:39:39 +0000 | |
| commit | 416c8f6105691e383f4e258fe507ef85c92d1f83 (patch) | |
| tree | e82052da39ab08cada0145d10cb8e7ddf03b0706 | |
| parent | 23b6eea5961cac16b0cf1b588be4139d5e426f0c (diff) | |
| parent | 6a983b1e8316795d0fe62531b7a7ced12244bf80 (diff) | |
Merge "Add falsing to Long Clicks on UMO" into tm-qpr-dev am: 6a983b1e83
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/20393164
Change-Id: Ief4b5aa16eaeec9b362bebc2cf407c9c0f3e2b95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/media/controls/ui/MediaControlPanel.java | 3 | ||||
| -rw-r--r-- | packages/SystemUI/tests/src/com/android/systemui/media/controls/ui/MediaControlPanelTest.kt | 27 |
2 files changed, 30 insertions, 0 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/media/controls/ui/MediaControlPanel.java b/packages/SystemUI/src/com/android/systemui/media/controls/ui/MediaControlPanel.java index 5b14cf34827a..215fa03c8c59 100644 --- a/packages/SystemUI/src/com/android/systemui/media/controls/ui/MediaControlPanel.java +++ b/packages/SystemUI/src/com/android/systemui/media/controls/ui/MediaControlPanel.java @@ -373,6 +373,7 @@ public class MediaControlPanel { mMediaViewController.attach(player, MediaViewController.TYPE.PLAYER); vh.getPlayer().setOnLongClickListener(v -> { + if (mFalsingManager.isFalseLongTap(FalsingManager.LOW_PENALTY)) return true; if (!mMediaViewController.isGutsVisible()) { openGuts(); return true; @@ -423,6 +424,7 @@ public class MediaControlPanel { mMediaViewController.attach(recommendations, MediaViewController.TYPE.RECOMMENDATION); mRecommendationViewHolder.getRecommendations().setOnLongClickListener(v -> { + if (mFalsingManager.isFalseLongTap(FalsingManager.LOW_PENALTY)) return true; if (!mMediaViewController.isGutsVisible()) { openGuts(); return true; @@ -1191,6 +1193,7 @@ public class MediaControlPanel { setSmartspaceRecItemOnClickListener(mediaCoverContainer, recommendation, itemIndex); // Bubble up the long-click event to the card. mediaCoverContainer.setOnLongClickListener(v -> { + if (mFalsingManager.isFalseLongTap(FalsingManager.LOW_PENALTY)) return true; View parent = (View) v.getParent(); if (parent != null) { parent.performLongClick(); diff --git a/packages/SystemUI/tests/src/com/android/systemui/media/controls/ui/MediaControlPanelTest.kt b/packages/SystemUI/tests/src/com/android/systemui/media/controls/ui/MediaControlPanelTest.kt index 81901569bde8..1ad2ca9b9db3 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/media/controls/ui/MediaControlPanelTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/media/controls/ui/MediaControlPanelTest.kt @@ -1137,6 +1137,19 @@ public class MediaControlPanelTest : SysuiTestCase() { /* ***** Guts tests for the player ***** */ @Test + fun player_longClick_isFalse() { + whenever(falsingManager.isFalseLongTap(FalsingManager.LOW_PENALTY)).thenReturn(true) + player.attachPlayer(viewHolder) + + val captor = ArgumentCaptor.forClass(View.OnLongClickListener::class.java) + verify(viewHolder.player).onLongClickListener = captor.capture() + + captor.value.onLongClick(viewHolder.player) + verify(mediaViewController, never()).openGuts() + verify(mediaViewController, never()).closeGuts() + } + + @Test fun player_longClickWhenGutsClosed_gutsOpens() { player.attachPlayer(viewHolder) player.bindPlayer(mediaData, KEY) @@ -1316,6 +1329,20 @@ public class MediaControlPanelTest : SysuiTestCase() { /* ***** Guts tests for the recommendations ***** */ @Test + fun recommendations_longClick_isFalse() { + whenever(falsingManager.isFalseLongTap(FalsingManager.LOW_PENALTY)).thenReturn(true) + player.attachRecommendation(recommendationViewHolder) + player.bindRecommendation(smartspaceData) + + val captor = ArgumentCaptor.forClass(View.OnLongClickListener::class.java) + verify(viewHolder.player).onLongClickListener = captor.capture() + + captor.value.onLongClick(viewHolder.player) + verify(mediaViewController, never()).openGuts() + verify(mediaViewController, never()).closeGuts() + } + + @Test fun recommendations_longClickWhenGutsClosed_gutsOpens() { player.attachRecommendation(recommendationViewHolder) player.bindRecommendation(smartspaceData) |