summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chiachang Wang <chiachangwang@google.com> 2022-02-10 00:50:30 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2022-02-10 00:50:30 +0000
commit4123af09c9acfa9fb120eabd9ac3e287d38aba72 (patch)
tree076d0d1477cc3e3370034a8a457a47c15ca0c480
parenta31dc6da2afbe5d4b100af1ea70c25fea1cbaa32 (diff)
parent7e34f92ab2c932fab27fe163ec93e6fe0bdb41f6 (diff)
Merge "Address API review feedback"
-rw-r--r--core/api/current.txt4
-rw-r--r--core/java/android/net/Ikev2VpnProfile.java5
-rw-r--r--core/java/android/net/PlatformVpnProfile.java2
3 files changed, 6 insertions, 5 deletions
diff --git a/core/api/current.txt b/core/api/current.txt
index 0ffc2c5198db..f33c4cbc518d 100644
--- a/core/api/current.txt
+++ b/core/api/current.txt
@@ -25224,7 +25224,7 @@ package android.net {
method @NonNull public android.net.Ikev2VpnProfile.Builder setAuthPsk(@NonNull byte[]);
method @NonNull public android.net.Ikev2VpnProfile.Builder setAuthUsernamePassword(@NonNull String, @NonNull String, @Nullable java.security.cert.X509Certificate);
method @NonNull public android.net.Ikev2VpnProfile.Builder setBypassable(boolean);
- method @NonNull public android.net.Ikev2VpnProfile.Builder setExcludeLocalRoutes(boolean);
+ method @NonNull public android.net.Ikev2VpnProfile.Builder setLocalRoutesExcluded(boolean);
method @NonNull public android.net.Ikev2VpnProfile.Builder setMaxMtu(int);
method @NonNull public android.net.Ikev2VpnProfile.Builder setMetered(boolean);
method @NonNull public android.net.Ikev2VpnProfile.Builder setProxy(@Nullable android.net.ProxyInfo);
@@ -25371,7 +25371,7 @@ package android.net {
}
public abstract class PlatformVpnProfile {
- method public final boolean getExcludeLocalRoutes();
+ method public final boolean areLocalRoutesExcluded();
method public final boolean getRequiresInternetValidation();
method public final int getType();
method @NonNull public final String getTypeString();
diff --git a/core/java/android/net/Ikev2VpnProfile.java b/core/java/android/net/Ikev2VpnProfile.java
index ec752fdbf45f..0fd3e034291b 100644
--- a/core/java/android/net/Ikev2VpnProfile.java
+++ b/core/java/android/net/Ikev2VpnProfile.java
@@ -547,7 +547,8 @@ public final class Ikev2VpnProfile extends PlatformVpnProfile {
if (profile.excludeLocalRoutes && !profile.isBypassable) {
Log.w(TAG, "ExcludeLocalRoutes should only be set in the bypassable VPN");
}
- builder.setExcludeLocalRoutes(profile.excludeLocalRoutes && profile.isBypassable);
+
+ builder.setLocalRoutesExcluded(profile.excludeLocalRoutes && profile.isBypassable);
builder.setRequiresInternetValidation(profile.requiresInternetValidation);
return builder.build();
@@ -1104,7 +1105,7 @@ public final class Ikev2VpnProfile extends PlatformVpnProfile {
*/
@NonNull
@RequiresFeature(PackageManager.FEATURE_IPSEC_TUNNELS)
- public Builder setExcludeLocalRoutes(boolean excludeLocalRoutes) {
+ public Builder setLocalRoutesExcluded(boolean excludeLocalRoutes) {
mExcludeLocalRoutes = excludeLocalRoutes;
return this;
}
diff --git a/core/java/android/net/PlatformVpnProfile.java b/core/java/android/net/PlatformVpnProfile.java
index 8bd1c8d07017..c0fb4cf4f3dd 100644
--- a/core/java/android/net/PlatformVpnProfile.java
+++ b/core/java/android/net/PlatformVpnProfile.java
@@ -83,7 +83,7 @@ public abstract class PlatformVpnProfile {
/**
* Returns whether the local traffic is exempted from the VPN.
*/
- public final boolean getExcludeLocalRoutes() {
+ public final boolean areLocalRoutesExcluded() {
return mExcludeLocalRoutes;
}