diff options
| author | 2018-09-18 14:59:30 -0700 | |
|---|---|---|
| committer | 2018-09-19 17:48:53 +0000 | |
| commit | 3ebb359229f6afff99fd4157387f92664585b080 (patch) | |
| tree | ae4f8e20f06eaa147f9437f3a9ad1660a2f0b735 | |
| parent | 093daeb9557b8b9265997bb59baf56aecb89fb9d (diff) | |
Log when the autofill service fails a callback.
Bug: 112417431
Bug: 116103297
Test: manual verification
Test: atest CtsAutoFillServiceTestCases # to make sure it didn't break anything
Change-Id: I2af70a3e4685693d32bab2814f60fdeb9c8b5159
3 files changed, 12 insertions, 0 deletions
diff --git a/core/java/android/service/autofill/FillCallback.java b/core/java/android/service/autofill/FillCallback.java index 1695c1306824..663bdcb707c9 100644 --- a/core/java/android/service/autofill/FillCallback.java +++ b/core/java/android/service/autofill/FillCallback.java @@ -19,6 +19,7 @@ package android.service.autofill; import android.annotation.Nullable; import android.app.Activity; import android.os.RemoteException; +import android.util.Log; /** * <p><code>FillCallback</code> handles autofill requests from the {@link AutofillService} into @@ -28,6 +29,9 @@ import android.os.RemoteException; * <a href="/guide/topics/text/autofill-services">Build autofill services</a>. */ public final class FillCallback { + + private static final String TAG = "FillCallback"; + private final IFillCallback mCallback; private final int mRequestId; private boolean mCalled; @@ -70,6 +74,7 @@ public final class FillCallback { * @param message error message to be displayed to the user. */ public void onFailure(@Nullable CharSequence message) { + Log.w(TAG, "onFailure(): " + (message == null ? null : message.length() + "_chars")); assertNotCalled(); mCalled = true; try { diff --git a/core/java/android/service/autofill/SaveCallback.java b/core/java/android/service/autofill/SaveCallback.java index 855981a544fd..e252e96f3fb4 100644 --- a/core/java/android/service/autofill/SaveCallback.java +++ b/core/java/android/service/autofill/SaveCallback.java @@ -21,6 +21,7 @@ import android.annotation.Nullable; import android.app.Activity; import android.content.IntentSender; import android.os.RemoteException; +import android.util.Log; import com.android.internal.util.Preconditions; @@ -29,6 +30,9 @@ import com.android.internal.util.Preconditions; * autofilled. */ public final class SaveCallback { + + private static final String TAG = "SaveCallback"; + private final ISaveCallback mCallback; private boolean mCalled; @@ -89,6 +93,7 @@ public final class SaveCallback { * @param message error message to be displayed to the user. */ public void onFailure(CharSequence message) { + Log.w(TAG, "onFailure(): " + (message == null ? null : message.length() + "_chars")); assertNotCalled(); mCalled = true; try { diff --git a/services/autofill/java/com/android/server/autofill/RemoteFillService.java b/services/autofill/java/com/android/server/autofill/RemoteFillService.java index ad80cc261bb3..2671327350be 100644 --- a/services/autofill/java/com/android/server/autofill/RemoteFillService.java +++ b/services/autofill/java/com/android/server/autofill/RemoteFillService.java @@ -587,6 +587,7 @@ final class RemoteFillService implements DeathRecipient { } final RemoteFillService remoteService = getService(); if (remoteService != null) { + if (sVerbose) Slog.v(LOG_TAG, "calling onFillRequest() for id=" + mRequest.getId()); try { remoteService.mAutoFillService.onFillRequest(mRequest, mCallback); } catch (RemoteException e) { @@ -659,6 +660,7 @@ final class RemoteFillService implements DeathRecipient { public void run() { final RemoteFillService remoteService = getService(); if (remoteService != null) { + if (sVerbose) Slog.v(LOG_TAG, "calling onSaveRequest()"); try { remoteService.mAutoFillService.onSaveRequest(mRequest, mCallback); } catch (RemoteException e) { |