summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Lee Shombert <shombert@google.com> 2025-01-15 13:46:09 -0800
committer Android (Google) Code Review <android-gerrit@google.com> 2025-01-15 13:46:09 -0800
commit3e3cc268e0bfcd3e1d857f359142b1a043e51f0c (patch)
tree688b188078f2e96a52bfa3358934394d884facff
parent333654315d3c0b4f9a6c824d24537c81ccd1dd35 (diff)
parent5253dcb17332c6fcb94e49a53f0dc86c2589d204 (diff)
Merge "Correct SQLiteOpenHelper lock creation" into main
-rw-r--r--core/java/android/database/sqlite/SQLiteOpenHelper.java11
1 files changed, 2 insertions, 9 deletions
diff --git a/core/java/android/database/sqlite/SQLiteOpenHelper.java b/core/java/android/database/sqlite/SQLiteOpenHelper.java
index 88d69b665c87..030c883924a7 100644
--- a/core/java/android/database/sqlite/SQLiteOpenHelper.java
+++ b/core/java/android/database/sqlite/SQLiteOpenHelper.java
@@ -182,17 +182,10 @@ public abstract class SQLiteOpenHelper implements AutoCloseable {
setOpenParamsBuilder(openParamsBuilder);
Object lock = null;
- if (mName == null || !Flags.concurrentOpenHelper()) {
+ if (!Flags.concurrentOpenHelper() || mName == null) {
lock = new Object();
} else {
- try {
- final String path = mContext.getDatabasePath(mName).getCanonicalPath();
- lock = sDbLock.computeIfAbsent(path, (String k) -> new Object());
- } catch (IOException e) {
- Log.d(TAG, "failed to construct db path for " + mName);
- // Ensure the lock is not null.
- lock = new Object();
- }
+ lock = sDbLock.computeIfAbsent(mName, (String k) -> new Object());
}
mLock = lock;
}