diff options
| author | 2024-07-08 08:20:23 +0000 | |
|---|---|---|
| committer | 2024-07-08 12:01:01 +0000 | |
| commit | 3bb5fd0f9e876155c9ab3647f5d2bb5bd46a644a (patch) | |
| tree | 682312023a5b756288fe2a80bbcc06b9eef8d9d3 | |
| parent | 274f9768f47dc429917d7531965b76617263e0af (diff) | |
Revert^2 "Remove expensive trace call in ProtoLog log call"
a72c380fc11dcfad37067bfc43f75bad1e0a46e7
Change-Id: I12aa16b55a8ee467762ae5665620085b111c9832
| -rw-r--r-- | core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java | 42 |
1 files changed, 15 insertions, 27 deletions
diff --git a/core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java b/core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java index 1fe24551bd0c..14d7d0378e3e 100644 --- a/core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java +++ b/core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java @@ -156,38 +156,26 @@ public class PerfettoProtoLogImpl implements IProtoLog { @Override public void log(LogLevel level, IProtoLogGroup group, long messageHash, int paramsMask, @Nullable Object[] args) { - Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "log"); - - try { - if (isProtoEnabled()) { - long tsNanos = SystemClock.elapsedRealtimeNanos(); - mBackgroundLoggingService.execute(() -> - logToProto(level, group, messageHash, paramsMask, args, tsNanos)); - } - if (group.isLogToLogcat()) { - logToLogcat(group.getTag(), level, messageHash, args); - } - } finally { - Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER); + if (isProtoEnabled()) { + long tsNanos = SystemClock.elapsedRealtimeNanos(); + mBackgroundLoggingService.execute(() -> + logToProto(level, group, messageHash, paramsMask, args, tsNanos)); + } + if (group.isLogToLogcat()) { + logToLogcat(group.getTag(), level, messageHash, args); } } @Override public void log(LogLevel logLevel, IProtoLogGroup group, String messageString, Object... args) { - Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "log"); - - try { - if (isProtoEnabled()) { - long tsNanos = SystemClock.elapsedRealtimeNanos(); - mBackgroundLoggingService.execute( - () -> logStringMessageToProto(logLevel, group, messageString, args, - tsNanos)); - } - if (group.isLogToLogcat()) { - logToLogcat(group.getTag(), logLevel, messageString, args); - } - } finally { - Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER); + if (isProtoEnabled()) { + long tsNanos = SystemClock.elapsedRealtimeNanos(); + mBackgroundLoggingService.execute( + () -> logStringMessageToProto(logLevel, group, messageString, args, + tsNanos)); + } + if (group.isLogToLogcat()) { + logToLogcat(group.getTag(), logLevel, messageString, args); } } |