diff options
| author | 2022-12-15 15:37:18 -0800 | |
|---|---|---|
| committer | 2022-12-19 17:16:45 -0800 | |
| commit | 341dc31a777a44d407c7dedc27ac44fb5ccb1fcd (patch) | |
| tree | 0f83aaefd819cd6c08371d200239149b271a2088 | |
| parent | 77c214e4cb0ee9665ce0eb8256f1d8fb97be16c0 (diff) | |
Defines flag for ravemped WPP UI (2/5).
This flag is owned in System UI and served to Wallpaper Picker (WPP)
through the existing content provider for quick affordances.
Bug: 262780448
Test: manually made sure that I can read the flag value in wallpaper
picker and its value matches whatever I set the flag to.
Change-Id: I26235a0718cc44c343713a5aef75750f4e59cfa7
4 files changed, 11 insertions, 6 deletions
diff --git a/packages/SystemUI/customization/src/com/android/systemui/shared/quickaffordance/data/content/KeyguardQuickAffordanceProviderContract.kt b/packages/SystemUI/customization/src/com/android/systemui/shared/quickaffordance/data/content/KeyguardQuickAffordanceProviderContract.kt index 923b99f0b750..e197752f2d3c 100644 --- a/packages/SystemUI/customization/src/com/android/systemui/shared/quickaffordance/data/content/KeyguardQuickAffordanceProviderContract.kt +++ b/packages/SystemUI/customization/src/com/android/systemui/shared/quickaffordance/data/content/KeyguardQuickAffordanceProviderContract.kt @@ -145,6 +145,9 @@ object KeyguardQuickAffordanceProviderContract { const val TABLE_NAME = "flags" val URI: Uri = BASE_URI.buildUpon().path(TABLE_NAME).build() + /** Flag denoting whether the Wallpaper Picker should use the new, revamped UI. */ + const val FLAG_NAME_REVAMPED_WALLPAPER_UI = "revamped_wallpaper_ui" + /** * Flag denoting whether the customizable lock screen quick affordances feature is enabled. */ diff --git a/packages/SystemUI/src/com/android/systemui/flags/Flags.kt b/packages/SystemUI/src/com/android/systemui/flags/Flags.kt index 4a65c4c7d3ff..21d75dcec083 100644 --- a/packages/SystemUI/src/com/android/systemui/flags/Flags.kt +++ b/packages/SystemUI/src/com/android/systemui/flags/Flags.kt @@ -412,7 +412,7 @@ object Flags { // TODO(b/261979569): Tracking Bug val QUICK_TAP_FLOW_FRAMEWORK = - unreleasedFlag(1401, "quick_tap_flow_framework", teamfood = false) + unreleasedFlag(1401, "quick_tap_flow_framework", teamfood = false) // 1500 - chooser // TODO(b/254512507): Tracking Bug diff --git a/packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/KeyguardQuickAffordanceInteractor.kt b/packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/KeyguardQuickAffordanceInteractor.kt index 8eace76632aa..9772cb9806a6 100644 --- a/packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/KeyguardQuickAffordanceInteractor.kt +++ b/packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/KeyguardQuickAffordanceInteractor.kt @@ -40,13 +40,13 @@ import com.android.systemui.shared.quickaffordance.data.content.KeyguardQuickAff import com.android.systemui.statusbar.phone.SystemUIDialog import com.android.systemui.statusbar.policy.KeyguardStateController import dagger.Lazy +import javax.inject.Inject import kotlinx.coroutines.flow.Flow import kotlinx.coroutines.flow.combine import kotlinx.coroutines.flow.flatMapLatest import kotlinx.coroutines.flow.flowOf import kotlinx.coroutines.flow.map import kotlinx.coroutines.flow.onStart -import javax.inject.Inject @SysUISingleton class KeyguardQuickAffordanceInteractor @@ -294,10 +294,7 @@ constructor( SystemUIDialog.setShowForAllUsers(dialog, true) SystemUIDialog.registerDismissListener(dialog) SystemUIDialog.setDialogSize(dialog) - launchAnimator.show( - dialog, - controller - ) + launchAnimator.show(dialog, controller) } } @@ -355,6 +352,10 @@ constructor( fun getPickerFlags(): List<KeyguardPickerFlag> { return listOf( KeyguardPickerFlag( + name = Contract.FlagsTable.FLAG_NAME_REVAMPED_WALLPAPER_UI, + value = featureFlags.isEnabled(Flags.REVAMPED_WALLPAPER_UI), + ), + KeyguardPickerFlag( name = Contract.FlagsTable.FLAG_NAME_CUSTOM_LOCK_SCREEN_QUICK_AFFORDANCES_ENABLED, value = featureFlags.isEnabled(Flags.CUSTOMIZABLE_LOCK_SCREEN_QUICK_AFFORDANCES), ), diff --git a/packages/SystemUI/tests/src/com/android/systemui/keyguard/KeyguardQuickAffordanceProviderTest.kt b/packages/SystemUI/tests/src/com/android/systemui/keyguard/KeyguardQuickAffordanceProviderTest.kt index cf9c91a1adb0..5e4a43f79711 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/keyguard/KeyguardQuickAffordanceProviderTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/keyguard/KeyguardQuickAffordanceProviderTest.kt @@ -170,6 +170,7 @@ class KeyguardQuickAffordanceProviderTest : SysuiTestCase() { FakeFeatureFlags().apply { set(Flags.CUSTOMIZABLE_LOCK_SCREEN_QUICK_AFFORDANCES, true) set(Flags.LOCKSCREEN_CUSTOM_CLOCKS, true) + set(Flags.REVAMPED_WALLPAPER_UI, true) }, repository = { quickAffordanceRepository }, launchAnimator = launchAnimator, |