summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Paul McLean <pmclean@google.com> 2015-05-13 15:41:00 -0700
committer Paul McLean <pmclean@google.com> 2015-05-13 15:41:00 -0700
commit338f27ab28a451d08417e4b2987aba1267b4c95d (patch)
treeddd886b6bc2ad8b6e3fa26b70431ed89dfba245f
parent20eec5bb794d0e1333ab3dca370f8b2ad2498416 (diff)
New policy for internal and wired device names.
For internal and unknowable wired devices, return the product name (i.e. "Nexus 7"). For connected devices with manufacturer-supplied product names, return those. Change getName() to getProductName(). Bug: 20880296 Change-Id: I67ef3d4c73b3acab368b0879faa26fa9127c21bb
-rw-r--r--api/current.txt2
-rw-r--r--api/system-current.txt2
-rw-r--r--media/java/android/media/AudioDeviceInfo.java5
-rw-r--r--services/core/java/com/android/server/WiredAccessoryManager.java4
4 files changed, 7 insertions, 6 deletions
diff --git a/api/current.txt b/api/current.txt
index 08d6a9dbebb2..47dfa2f4220f 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -14696,7 +14696,7 @@ package android.media {
method public int[] getChannelMasks();
method public int[] getFormats();
method public int getId();
- method public java.lang.CharSequence getName();
+ method public java.lang.CharSequence getProductName();
method public int[] getSampleRates();
method public int getType();
method public boolean isSink();
diff --git a/api/system-current.txt b/api/system-current.txt
index 7cf49e86f20c..f490d68c8c9a 100644
--- a/api/system-current.txt
+++ b/api/system-current.txt
@@ -15906,7 +15906,7 @@ package android.media {
method public int[] getChannelMasks();
method public int[] getFormats();
method public int getId();
- method public java.lang.CharSequence getName();
+ method public java.lang.CharSequence getProductName();
method public int[] getSampleRates();
method public int getType();
method public boolean isSink();
diff --git a/media/java/android/media/AudioDeviceInfo.java b/media/java/android/media/AudioDeviceInfo.java
index 566f8dc4ee50..b4c109b6db46 100644
--- a/media/java/android/media/AudioDeviceInfo.java
+++ b/media/java/android/media/AudioDeviceInfo.java
@@ -121,8 +121,9 @@ public final class AudioDeviceInfo {
/**
* @return The human-readable name of the audio device.
*/
- public CharSequence getName() {
- return mPort.name();
+ public CharSequence getProductName() {
+ String portName = mPort.name();
+ return portName.length() != 0 ? portName : android.os.Build.MODEL;
}
/**
diff --git a/services/core/java/com/android/server/WiredAccessoryManager.java b/services/core/java/com/android/server/WiredAccessoryManager.java
index 0de8c8dd9df5..e0e6070a811a 100644
--- a/services/core/java/com/android/server/WiredAccessoryManager.java
+++ b/services/core/java/com/android/server/WiredAccessoryManager.java
@@ -216,9 +216,9 @@ final class WiredAccessoryManager implements WiredAccessoryCallbacks {
mWakeLock.acquire();
- Log.i(TAG, "MSG_NEW_DEVICE_STATE ");
+ Log.i(TAG, "MSG_NEW_DEVICE_STATE");
Message msg = mHandler.obtainMessage(MSG_NEW_DEVICE_STATE, headsetState,
- mHeadsetState, newName);
+ mHeadsetState, "");
mHandler.sendMessage(msg);
mHeadsetState = headsetState;