diff options
| author | 2018-09-11 11:08:17 -0700 | |
|---|---|---|
| committer | 2018-09-11 21:58:35 +0000 | |
| commit | 332d34fa13008d72f147ec39038b10e703d6640d (patch) | |
| tree | 75690495fa24b4bd6ff2362876ddea8ba54f0af4 | |
| parent | a1d17b4d9990b31c7002dd4ca3f3a03eb99b767e (diff) | |
Dark version of error/crash dialogs
Test: visual
Change-Id: Icb8bd9c5ebcb49970104966f16cb07d18952436e
Fixes: 114519659
| -rw-r--r-- | core/res/res/values-night/themes_device_defaults.xml | 3 | ||||
| -rw-r--r-- | core/res/res/values-television/themes.xml | 2 | ||||
| -rw-r--r-- | core/res/res/values-watch/themes.xml | 2 | ||||
| -rw-r--r-- | core/res/res/values/symbols.xml | 2 | ||||
| -rw-r--r-- | core/res/res/values/themes.xml | 7 | ||||
| -rw-r--r-- | core/res/res/values/themes_device_defaults.xml | 7 | ||||
| -rw-r--r-- | services/core/java/com/android/server/am/BaseErrorDialog.java | 2 |
7 files changed, 14 insertions, 11 deletions
diff --git a/core/res/res/values-night/themes_device_defaults.xml b/core/res/res/values-night/themes_device_defaults.xml index 5e3675ac6c3e..c8d4d05a3507 100644 --- a/core/res/res/values-night/themes_device_defaults.xml +++ b/core/res/res/values-night/themes_device_defaults.xml @@ -51,4 +51,7 @@ easier. --> <!-- DeviceDefault theme for a window that should look like the Settings app. --> <style name="Theme.DeviceDefault.Settings" parent="Theme.DeviceDefault"/> + + <!-- Theme for the dialog shown when an app crashes or ANRs. --> + <style name="Theme.DeviceDefault.Dialog.AppError" parent="Theme.DeviceDefault.Dialog.Alert" /> </resources> diff --git a/core/res/res/values-television/themes.xml b/core/res/res/values-television/themes.xml index 377982a409c9..0712cbcfc024 100644 --- a/core/res/res/values-television/themes.xml +++ b/core/res/res/values-television/themes.xml @@ -15,7 +15,7 @@ --> <resources> <style name="Theme.Dialog.Alert" parent="Theme.Leanback.Light.Dialog.Alert" /> - <style name="Theme.Dialog.AppError" parent="Theme.Leanback.Dialog.AppError" /> + <style name="Theme.DeviceDefault.Dialog.AppError" parent="Theme.Leanback.Dialog.AppError" /> <style name="Theme.Holo.Dialog.Alert" parent="Theme.Leanback.Dialog.Alert" /> <style name="Theme.Holo.Light.Dialog.Alert" parent="Theme.Leanback.Light.Dialog.Alert" /> <style name="Theme.Material.Dialog.Alert" parent="Theme.Leanback.Dialog.Alert" /> diff --git a/core/res/res/values-watch/themes.xml b/core/res/res/values-watch/themes.xml index 04df1809878a..1be47baf4e7f 100644 --- a/core/res/res/values-watch/themes.xml +++ b/core/res/res/values-watch/themes.xml @@ -15,7 +15,7 @@ --> <resources> <!-- Theme for the dialog shown when an app crashes or ANRs. Override to make it dark. --> - <style name="Theme.Dialog.AppError" parent="Theme.DeviceDefault.Dialog.Alert"> + <style name="Theme.DeviceDefault.Dialog.AppError" parent="Theme.DeviceDefault.Dialog.Alert"> <item name="windowContentTransitions">false</item> <item name="windowActivityTransitions">false</item> <item name="windowCloseOnTouchOutside">false</item> diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 92cca72e055a..389278f87fa1 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -2099,7 +2099,7 @@ <java-symbol type="string" name="vpn_lockdown_error" /> <java-symbol type="string" name="vpn_lockdown_config" /> <java-symbol type="string" name="wallpaper_binding_label" /> - <java-symbol type="style" name="Theme.Dialog.AppError" /> + <java-symbol type="style" name="Theme.DeviceDefault.Dialog.AppError" /> <java-symbol type="style" name="Theme.Leanback.Dialog.Alert" /> <java-symbol type="style" name="Theme.Toast" /> <java-symbol type="xml" name="storage_list" /> diff --git a/core/res/res/values/themes.xml b/core/res/res/values/themes.xml index 3937af5c933f..a7530cea5d73 100644 --- a/core/res/res/values/themes.xml +++ b/core/res/res/values/themes.xml @@ -869,13 +869,6 @@ please see themes_device_defaults.xml. <!-- System themes --> <eat-comment /> - <!-- Theme for the dialog shown when an app crashes or ANRs. --> - <style name="Theme.Dialog.AppError" parent="Theme.DeviceDefault.Light.Dialog.Alert"> - <item name="windowContentTransitions">false</item> - <item name="windowActivityTransitions">false</item> - <item name="windowCloseOnTouchOutside">false</item> - </style> - <!-- Special theme for the recent apps dialog, to allow customization with overlays. --> <style name="Theme.Dialog.RecentApplications" parent="Theme.DeviceDefault.Light.Dialog"> diff --git a/core/res/res/values/themes_device_defaults.xml b/core/res/res/values/themes_device_defaults.xml index 14e5082bdebb..92096abfcfab 100644 --- a/core/res/res/values/themes_device_defaults.xml +++ b/core/res/res/values/themes_device_defaults.xml @@ -719,6 +719,13 @@ easier. <item name="toolbarStyle">@style/Widget.DeviceDefault.Toolbar</item> </style> + <!-- Theme for the dialog shown when an app crashes or ANRs. --> + <style name="Theme.DeviceDefault.Dialog.AppError" parent="Theme.DeviceDefault.Light.Dialog.Alert"> + <item name="windowContentTransitions">false</item> + <item name="windowActivityTransitions">false</item> + <item name="windowCloseOnTouchOutside">false</item> + </style> + <style name="Theme.DeviceDefault.SearchBar" parent="Theme.Material.SearchBar"> <!-- Color palette --> <item name="colorPrimary">@color/primary_device_default_dark</item> diff --git a/services/core/java/com/android/server/am/BaseErrorDialog.java b/services/core/java/com/android/server/am/BaseErrorDialog.java index 347a357aae04..cd4d6a3e14c5 100644 --- a/services/core/java/com/android/server/am/BaseErrorDialog.java +++ b/services/core/java/com/android/server/am/BaseErrorDialog.java @@ -33,7 +33,7 @@ class BaseErrorDialog extends AlertDialog { private boolean mConsuming = true; public BaseErrorDialog(Context context) { - super(context, com.android.internal.R.style.Theme_Dialog_AppError); + super(context, com.android.internal.R.style.Theme_DeviceDefault_Dialog_AppError); context.assertRuntimeOverlayThemable(); getWindow().setType(WindowManager.LayoutParams.TYPE_SYSTEM_ALERT); |