summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Robin Lee <rgl@google.com> 2016-05-26 23:41:27 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2016-05-26 23:41:28 +0000
commit32ceb9c801a86f901ec8230eec301c30e1deff3b (patch)
tree1452a166d4826730f2fbb9d62807e851145a1467
parent0d35765ca343ae7b04df7a93c233e5b6860eec22 (diff)
parent628ae0d84180c5f7c52725e02506021e532ed252 (diff)
Merge "Move VPN restriction check into setup dialog" into nyc-dev
-rw-r--r--packages/VpnDialogs/src/com/android/vpndialogs/ConfirmDialog.java5
-rw-r--r--services/core/java/com/android/server/connectivity/Vpn.java3
2 files changed, 6 insertions, 2 deletions
diff --git a/packages/VpnDialogs/src/com/android/vpndialogs/ConfirmDialog.java b/packages/VpnDialogs/src/com/android/vpndialogs/ConfirmDialog.java
index f0ca44162dad..badc31e6df92 100644
--- a/packages/VpnDialogs/src/com/android/vpndialogs/ConfirmDialog.java
+++ b/packages/VpnDialogs/src/com/android/vpndialogs/ConfirmDialog.java
@@ -25,6 +25,7 @@ import android.os.Bundle;
import android.os.RemoteException;
import android.os.ServiceManager;
import android.os.UserHandle;
+import android.os.UserManager;
import android.text.Html;
import android.text.Html.ImageGetter;
import android.util.Log;
@@ -55,6 +56,10 @@ public class ConfirmDialog extends AlertActivity
finish();
return;
}
+ if (UserManager.get(this).hasUserRestriction(UserManager.DISALLOW_CONFIG_VPN)) {
+ finish();
+ return;
+ }
View view = View.inflate(this, R.layout.confirm, null);
((TextView) view.findViewById(R.id.warning)).setText(
Html.fromHtml(getString(R.string.warning, getVpnLabel()),
diff --git a/services/core/java/com/android/server/connectivity/Vpn.java b/services/core/java/com/android/server/connectivity/Vpn.java
index dd9baf4909c7..1698ab5204e2 100644
--- a/services/core/java/com/android/server/connectivity/Vpn.java
+++ b/services/core/java/com/android/server/connectivity/Vpn.java
@@ -555,8 +555,7 @@ public class Vpn {
try {
// Restricted users are not allowed to create VPNs, they are tied to Owner
UserInfo user = mgr.getUserInfo(mUserHandle);
- if (user.isRestricted() || mgr.hasUserRestriction(UserManager.DISALLOW_CONFIG_VPN,
- new UserHandle(mUserHandle))) {
+ if (user.isRestricted()) {
throw new SecurityException("Restricted users cannot establish VPNs");
}