diff options
| author | 2022-11-09 20:47:35 +0000 | |
|---|---|---|
| committer | 2022-12-13 08:04:00 +0000 | |
| commit | 30413763cc2640bbecf45cd15ff7ed40a4c1722a (patch) | |
| tree | a66f72b7442ba73183d9297b553361b2022e043a | |
| parent | e77864097f9341a69af9936b05d1d7158fead78f (diff) | |
1/ Define biometric_auth_pattern_view_size for pattern view size
1. Set biometric_auth_pattern_view_size: 348dp (portrait)
2. Set resilience size 248dp~348dp for landscape mode
   biometric_auth_pattern_view_(max_)size
3. Set 348dp size for sw410dp when display density < 560
   Set 248dp-348dp resilience size for sw410dp-land
4. Add sw392dp sw392dp-land with density 440 projects
5. Set sw600dp/sw720dp/sw800dp for large screen device
6. Reference dimen biometric_auth_pattern_view_size in style
Bug: 234847272
Bug: 243008023
Bug: 243699695
Test: manual
Test: atest SystemUITests
Change-Id: I2152cb7eab46a772262644f48bc88b39729220b5
Merged-In: I2152cb7eab46a772262644f48bc88b39729220b5
18 files changed, 118 insertions, 30 deletions
diff --git a/packages/SystemUI/res/layout-land/auth_credential_pattern_view.xml b/packages/SystemUI/res/layout-land/auth_credential_pattern_view.xml index a3dd334bd667..3505a3e6b6bf 100644 --- a/packages/SystemUI/res/layout-land/auth_credential_pattern_view.xml +++ b/packages/SystemUI/res/layout-land/auth_credential_pattern_view.xml @@ -71,8 +71,8 @@          <com.android.internal.widget.LockPatternView              android:id="@+id/lockPattern"              android:layout_gravity="center" -            android:layout_width="match_parent" -            android:layout_height="match_parent"/> +            android:layout_width="@dimen/biometric_auth_pattern_view_size" +            android:layout_height="@dimen/biometric_auth_pattern_view_size"/>          <TextView              android:id="@+id/error" diff --git a/packages/SystemUI/res/layout/auth_credential_pattern_view.xml b/packages/SystemUI/res/layout/auth_credential_pattern_view.xml index 4af997017bba..147ea8221beb 100644 --- a/packages/SystemUI/res/layout/auth_credential_pattern_view.xml +++ b/packages/SystemUI/res/layout/auth_credential_pattern_view.xml @@ -67,8 +67,8 @@          <com.android.internal.widget.LockPatternView              android:id="@+id/lockPattern"              android:layout_gravity="center" -            android:layout_width="match_parent" -            android:layout_height="match_parent"/> +            android:layout_width="@dimen/biometric_auth_pattern_view_size" +            android:layout_height="@dimen/biometric_auth_pattern_view_size"/>          <TextView              android:id="@+id/error" diff --git a/packages/SystemUI/res/values-land/dimens.xml b/packages/SystemUI/res/values-land/dimens.xml index 49ef330dcc52..fff25448b2e4 100644 --- a/packages/SystemUI/res/values-land/dimens.xml +++ b/packages/SystemUI/res/values-land/dimens.xml @@ -40,6 +40,10 @@      <dimen name="biometric_dialog_button_negative_max_width">140dp</dimen>      <dimen name="biometric_dialog_button_positive_max_width">116dp</dimen> +    <!-- Lock pattern view size, align sysui biometric_auth_pattern_view_size --> +    <dimen name="biometric_auth_pattern_view_size">248dp</dimen> +    <dimen name="biometric_auth_pattern_view_max_size">348dp</dimen> +      <dimen name="global_actions_power_dialog_item_height">130dp</dimen>      <dimen name="global_actions_power_dialog_item_bottom_margin">35dp</dimen> diff --git a/packages/SystemUI/res/values-land/styles.xml b/packages/SystemUI/res/values-land/styles.xml index aefd9981d02e..a0e721e571d8 100644 --- a/packages/SystemUI/res/values-land/styles.xml +++ b/packages/SystemUI/res/values-land/styles.xml @@ -29,11 +29,11 @@      <style name="AuthCredentialPatternContainerStyle">          <item name="android:gravity">center</item> -        <item name="android:maxHeight">320dp</item> -        <item name="android:maxWidth">320dp</item> -        <item name="android:minHeight">200dp</item> -        <item name="android:minWidth">200dp</item> -        <item name="android:paddingHorizontal">60dp</item> +        <item name="android:maxHeight">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:maxWidth">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:minHeight">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:minWidth">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:paddingHorizontal">32dp</item>          <item name="android:paddingVertical">20dp</item>      </style> diff --git a/packages/SystemUI/res/values-sw360dp/dimens.xml b/packages/SystemUI/res/values-sw360dp/dimens.xml index 65ca70bac0dc..03365b3d8c4f 100644 --- a/packages/SystemUI/res/values-sw360dp/dimens.xml +++ b/packages/SystemUI/res/values-sw360dp/dimens.xml @@ -25,5 +25,8 @@      <!-- Home Controls -->      <dimen name="global_actions_side_margin">12dp</dimen> + +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">298dp</dimen>  </resources> diff --git a/packages/SystemUI/res/values-sw392dp-land/dimens.xml b/packages/SystemUI/res/values-sw392dp-land/dimens.xml new file mode 100644 index 000000000000..1e26a699f85a --- /dev/null +++ b/packages/SystemUI/res/values-sw392dp-land/dimens.xml @@ -0,0 +1,21 @@ +<!-- +  ~ Copyright (C) 2022 The Android Open Source Project +  ~ +  ~ Licensed under the Apache License, Version 2.0 (the "License"); +  ~ you may not use this file except in compliance with the License. +  ~ You may obtain a copy of the License at +  ~ +  ~      http://www.apache.org/licenses/LICENSE-2.0 +  ~ +  ~ Unless required by applicable law or agreed to in writing, software +  ~ distributed under the License is distributed on an "AS IS" BASIS, +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +  ~ See the License for the specific language governing permissions and +  ~ limitations under the License. +  --> + +<resources> +    <!-- Lock pattern view size, align sysui biometric_auth_pattern_view_size --> +    <dimen name="biometric_auth_pattern_view_size">248dp</dimen> +    <dimen name="biometric_auth_pattern_view_max_size">248dp</dimen> +</resources>
\ No newline at end of file diff --git a/packages/SystemUI/res/values-sw392dp/dimens.xml b/packages/SystemUI/res/values-sw392dp/dimens.xml index 78279ca4f520..96af3c13f32e 100644 --- a/packages/SystemUI/res/values-sw392dp/dimens.xml +++ b/packages/SystemUI/res/values-sw392dp/dimens.xml @@ -24,5 +24,8 @@      <!-- Home Controls -->      <dimen name="global_actions_side_margin">16dp</dimen> + +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">298dp</dimen>  </resources> diff --git a/packages/SystemUI/res/values-sw410dp-land/dimens.xml b/packages/SystemUI/res/values-sw410dp-land/dimens.xml new file mode 100644 index 000000000000..c4d9b9b92f57 --- /dev/null +++ b/packages/SystemUI/res/values-sw410dp-land/dimens.xml @@ -0,0 +1,21 @@ +<!-- +  ~ Copyright (C) 2022 The Android Open Source Project +  ~ +  ~ Licensed under the Apache License, Version 2.0 (the "License"); +  ~ you may not use this file except in compliance with the License. +  ~ You may obtain a copy of the License at +  ~ +  ~      http://www.apache.org/licenses/LICENSE-2.0 +  ~ +  ~ Unless required by applicable law or agreed to in writing, software +  ~ distributed under the License is distributed on an "AS IS" BASIS, +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +  ~ See the License for the specific language governing permissions and +  ~ limitations under the License. +  --> + +<resources> +    <!-- Lock pattern view size, align sysui biometric_auth_pattern_view_size --> +    <dimen name="biometric_auth_pattern_view_size">248dp</dimen> +    <dimen name="biometric_auth_pattern_view_max_size">348dp</dimen> +</resources>
\ No newline at end of file diff --git a/packages/SystemUI/res/values-sw410dp/dimens.xml b/packages/SystemUI/res/values-sw410dp/dimens.xml index 7da47e5089be..ff6e005a94c7 100644 --- a/packages/SystemUI/res/values-sw410dp/dimens.xml +++ b/packages/SystemUI/res/values-sw410dp/dimens.xml @@ -27,4 +27,6 @@      <dimen name="global_actions_grid_item_side_margin">12dp</dimen>      <dimen name="global_actions_grid_item_height">72dp</dimen> +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">348dp</dimen>  </resources> diff --git a/packages/SystemUI/res/values-sw600dp-land/styles.xml b/packages/SystemUI/res/values-sw600dp-land/styles.xml index 8148d3dfaf7d..c535c6416106 100644 --- a/packages/SystemUI/res/values-sw600dp-land/styles.xml +++ b/packages/SystemUI/res/values-sw600dp-land/styles.xml @@ -18,10 +18,10 @@      <style name="AuthCredentialPatternContainerStyle">          <item name="android:gravity">center</item> -        <item name="android:maxHeight">420dp</item> -        <item name="android:maxWidth">420dp</item> -        <item name="android:minHeight">200dp</item> -        <item name="android:minWidth">200dp</item> +        <item name="android:maxHeight">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:maxWidth">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:minHeight">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:minWidth">@dimen/biometric_auth_pattern_view_size</item>          <item name="android:paddingHorizontal">120dp</item>          <item name="android:paddingVertical">40dp</item>      </style> diff --git a/packages/SystemUI/res/values-sw600dp-port/styles.xml b/packages/SystemUI/res/values-sw600dp-port/styles.xml index 771de08cb360..32eefa7316b2 100644 --- a/packages/SystemUI/res/values-sw600dp-port/styles.xml +++ b/packages/SystemUI/res/values-sw600dp-port/styles.xml @@ -26,10 +26,10 @@      <style name="AuthCredentialPatternContainerStyle">          <item name="android:gravity">center</item> -        <item name="android:maxHeight">420dp</item> -        <item name="android:maxWidth">420dp</item> -        <item name="android:minHeight">200dp</item> -        <item name="android:minWidth">200dp</item> +        <item name="android:maxHeight">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:maxWidth">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:minHeight">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:minWidth">@dimen/biometric_auth_pattern_view_size</item>          <item name="android:paddingHorizontal">180dp</item>          <item name="android:paddingVertical">80dp</item>      </style> diff --git a/packages/SystemUI/res/values-sw600dp/dimens.xml b/packages/SystemUI/res/values-sw600dp/dimens.xml index 599bf30a5135..9bc0dde49b4c 100644 --- a/packages/SystemUI/res/values-sw600dp/dimens.xml +++ b/packages/SystemUI/res/values-sw600dp/dimens.xml @@ -92,4 +92,6 @@      <dimen name="lockscreen_shade_status_bar_transition_distance">@dimen/lockscreen_shade_full_transition_distance</dimen>      <dimen name="lockscreen_shade_keyguard_transition_distance">@dimen/lockscreen_shade_media_transition_distance</dimen> +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">348dp</dimen>  </resources> diff --git a/packages/SystemUI/res/values-sw720dp-land/styles.xml b/packages/SystemUI/res/values-sw720dp-land/styles.xml index f9ed67d89de7..6a70ebd07ad2 100644 --- a/packages/SystemUI/res/values-sw720dp-land/styles.xml +++ b/packages/SystemUI/res/values-sw720dp-land/styles.xml @@ -18,10 +18,10 @@      <style name="AuthCredentialPatternContainerStyle">          <item name="android:gravity">center</item> -        <item name="android:maxHeight">420dp</item> -        <item name="android:maxWidth">420dp</item> -        <item name="android:minHeight">200dp</item> -        <item name="android:minWidth">200dp</item> +        <item name="android:maxHeight">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:maxWidth">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:minHeight">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:minWidth">@dimen/biometric_auth_pattern_view_size</item>          <item name="android:paddingHorizontal">120dp</item>          <item name="android:paddingVertical">40dp</item>      </style> diff --git a/packages/SystemUI/res/values-sw720dp-port/styles.xml b/packages/SystemUI/res/values-sw720dp-port/styles.xml index 78d299c483e6..0a46e08da22a 100644 --- a/packages/SystemUI/res/values-sw720dp-port/styles.xml +++ b/packages/SystemUI/res/values-sw720dp-port/styles.xml @@ -26,10 +26,10 @@      <style name="AuthCredentialPatternContainerStyle">          <item name="android:gravity">center</item> -        <item name="android:maxHeight">420dp</item> -        <item name="android:maxWidth">420dp</item> -        <item name="android:minHeight">200dp</item> -        <item name="android:minWidth">200dp</item> +        <item name="android:maxHeight">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:maxWidth">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:minHeight">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:minWidth">@dimen/biometric_auth_pattern_view_size</item>          <item name="android:paddingHorizontal">240dp</item>          <item name="android:paddingVertical">120dp</item>      </style> diff --git a/packages/SystemUI/res/values-sw720dp/dimens.xml b/packages/SystemUI/res/values-sw720dp/dimens.xml index 07050171470a..927059aa7e40 100644 --- a/packages/SystemUI/res/values-sw720dp/dimens.xml +++ b/packages/SystemUI/res/values-sw720dp/dimens.xml @@ -22,5 +22,8 @@      <dimen name="controls_padding_horizontal">75dp</dimen>      <dimen name="large_screen_shade_header_height">56dp</dimen> + +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">348dp</dimen>  </resources> diff --git a/packages/SystemUI/res/values-sw800dp/dimens.xml b/packages/SystemUI/res/values-sw800dp/dimens.xml new file mode 100644 index 000000000000..0d82217456e4 --- /dev/null +++ b/packages/SystemUI/res/values-sw800dp/dimens.xml @@ -0,0 +1,24 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- +  ~ Copyright (C) 2022 The Android Open Source Project +  ~ +  ~ Licensed under the Apache License, Version 2.0 (the "License"); +  ~ you may not use this file except in compliance with the License. +  ~ You may obtain a copy of the License at +  ~ +  ~      http://www.apache.org/licenses/LICENSE-2.0 +  ~ +  ~ Unless required by applicable law or agreed to in writing, software +  ~ distributed under the License is distributed on an "AS IS" BASIS, +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +  ~ See the License for the specific language governing permissions and +  ~ limitations under the License. +  --> + +<!-- These resources are around just to allow their values to be customized +     for different hardware and product builds. --> +<resources> + +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">348dp</dimen> +</resources> diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml index f3d2638c4ee7..6c04da813a50 100644 --- a/packages/SystemUI/res/values/dimens.xml +++ b/packages/SystemUI/res/values/dimens.xml @@ -961,6 +961,10 @@      <!-- Biometric Auth Credential values -->      <dimen name="biometric_auth_icon_size">48dp</dimen> +    <!-- Biometric Auth pattern view size, better to align keyguard_security_width --> +    <dimen name="biometric_auth_pattern_view_size">348dp</dimen> +    <dimen name="biometric_auth_pattern_view_max_size">348dp</dimen> +      <!-- Starting text size in sp of batteryLevel for wireless charging animation -->      <item name="wireless_charging_anim_battery_level_text_size_start" format="float" type="dimen">          0 diff --git a/packages/SystemUI/res/values/styles.xml b/packages/SystemUI/res/values/styles.xml index b11b6d633f14..9846fc251a27 100644 --- a/packages/SystemUI/res/values/styles.xml +++ b/packages/SystemUI/res/values/styles.xml @@ -251,11 +251,12 @@      <style name="AuthCredentialPatternContainerStyle">          <item name="android:gravity">center</item> -        <item name="android:maxHeight">420dp</item> -        <item name="android:maxWidth">420dp</item> -        <item name="android:minHeight">200dp</item> -        <item name="android:minWidth">200dp</item> -        <item name="android:padding">20dp</item> +        <item name="android:maxHeight">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:maxWidth">@dimen/biometric_auth_pattern_view_max_size</item> +        <item name="android:minHeight">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:minWidth">@dimen/biometric_auth_pattern_view_size</item> +        <item name="android:paddingHorizontal">32dp</item> +        <item name="android:paddingVertical">20dp</item>      </style>      <style name="AuthCredentialPinPasswordContainerStyle">  |