summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Dmitri Plotnikov <dplotnikov@google.com> 2021-07-16 01:05:18 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2021-07-16 01:05:18 +0000
commit2c06c196c2c86b2bc249ea645fe66b72e955926b (patch)
tree521e4c6e4759469ee9a44ab3fa011d1fd7cab04d
parentcde82d50d448a91600f167aba286598266523ea7 (diff)
parentd6956bc2872eea041938c930563598f4dea33150 (diff)
Merge "Fix BatteryStatsImplTest." into sc-dev am: 4162c032bf am: d6956bc287
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15291010 Change-Id: I19bc29d6bf83c8d077e9b8961fcc41100edf3f27
-rw-r--r--core/java/com/android/internal/os/BatteryStatsImpl.java3
-rw-r--r--core/tests/coretests/src/com/android/internal/os/BatteryStatsImplTest.java5
-rw-r--r--core/tests/coretests/src/com/android/internal/os/MockBatteryStatsImpl.java5
3 files changed, 9 insertions, 4 deletions
diff --git a/core/java/com/android/internal/os/BatteryStatsImpl.java b/core/java/com/android/internal/os/BatteryStatsImpl.java
index 3594e64a316c..84ef5a19772e 100644
--- a/core/java/com/android/internal/os/BatteryStatsImpl.java
+++ b/core/java/com/android/internal/os/BatteryStatsImpl.java
@@ -1106,8 +1106,9 @@ public class BatteryStatsImpl extends BatteryStats {
@VisibleForTesting
protected PowerProfile mPowerProfile;
+ @VisibleForTesting
@GuardedBy("this")
- final Constants mConstants;
+ protected final Constants mConstants;
/*
* Holds a SamplingTimer associated with each Resource Power Manager state and voter,
diff --git a/core/tests/coretests/src/com/android/internal/os/BatteryStatsImplTest.java b/core/tests/coretests/src/com/android/internal/os/BatteryStatsImplTest.java
index 24baa93337ba..cca66420c596 100644
--- a/core/tests/coretests/src/com/android/internal/os/BatteryStatsImplTest.java
+++ b/core/tests/coretests/src/com/android/internal/os/BatteryStatsImplTest.java
@@ -69,11 +69,11 @@ public class BatteryStatsImplTest {
when(mKernelSingleUidTimeReader.singleUidCpuTimesAvailable()).thenReturn(true);
mBatteryStatsImpl = new MockBatteryStatsImpl()
.setKernelCpuUidFreqTimeReader(mKernelUidCpuFreqTimeReader)
- .setKernelSingleUidTimeReader(mKernelSingleUidTimeReader);
+ .setKernelSingleUidTimeReader(mKernelSingleUidTimeReader)
+ .setTrackingCpuByProcStateEnabled(true);
}
@Test
- @SkipPresubmit("b/180015146")
public void testUpdateProcStateCpuTimes() {
mBatteryStatsImpl.setOnBatteryInternal(true);
mBatteryStatsImpl.updateTimeBasesLocked(false, Display.STATE_ON, 0, 0);
@@ -231,7 +231,6 @@ public class BatteryStatsImplTest {
}
@Test
- @SkipPresubmit("b/180015146")
public void testCopyFromAllUidsCpuTimes() {
mBatteryStatsImpl.setOnBatteryInternal(false);
mBatteryStatsImpl.updateTimeBasesLocked(false, Display.STATE_ON, 0, 0);
diff --git a/core/tests/coretests/src/com/android/internal/os/MockBatteryStatsImpl.java b/core/tests/coretests/src/com/android/internal/os/MockBatteryStatsImpl.java
index 80def71ce812..99d576d259ec 100644
--- a/core/tests/coretests/src/com/android/internal/os/MockBatteryStatsImpl.java
+++ b/core/tests/coretests/src/com/android/internal/os/MockBatteryStatsImpl.java
@@ -174,6 +174,11 @@ public class MockBatteryStatsImpl extends BatteryStatsImpl {
return this;
}
+ public MockBatteryStatsImpl setTrackingCpuByProcStateEnabled(boolean enabled) {
+ mConstants.TRACK_CPU_TIMES_BY_PROC_STATE = enabled;
+ return this;
+ }
+
public SparseIntArray getPendingUids() {
return mPendingUids;
}