summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Massimo Carli <mcarli@google.com> 2025-01-13 09:08:07 -0800
committer Android (Google) Code Review <android-gerrit@google.com> 2025-01-13 09:08:07 -0800
commit28cef9b76c59eb2e8dd4b2614a70217608b978fb (patch)
tree20d0ddbc5a8def7184d8dfdf8f8438404f6811a9
parentf70c5a8b8e089c8de1df2e6bd6759530fcacb8c2 (diff)
parentccc67042d5e16b6043a7bade3cb0a218413d5d61 (diff)
Merge "[46/n] Simplify DesktopAppCompatAspectRatioPolicy naming" into main
-rw-r--r--services/core/java/com/android/server/wm/AppCompatController.java8
-rw-r--r--services/core/java/com/android/server/wm/AppCompatUtils.java2
-rw-r--r--services/core/java/com/android/server/wm/DesktopModeBoundsCalculator.java4
-rw-r--r--services/tests/wmtests/src/com/android/server/wm/DesktopAppCompatAspectRatioPolicyTests.java6
-rw-r--r--services/tests/wmtests/src/com/android/server/wm/DesktopModeLaunchParamsModifierTests.java20
-rw-r--r--services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java2
6 files changed, 21 insertions, 21 deletions
diff --git a/services/core/java/com/android/server/wm/AppCompatController.java b/services/core/java/com/android/server/wm/AppCompatController.java
index 622ec2237dc7..1a6c9a1a8797 100644
--- a/services/core/java/com/android/server/wm/AppCompatController.java
+++ b/services/core/java/com/android/server/wm/AppCompatController.java
@@ -35,7 +35,7 @@ class AppCompatController {
@NonNull
private final AppCompatReachabilityPolicy mReachabilityPolicy;
@NonNull
- private final DesktopAppCompatAspectRatioPolicy mDesktopAppCompatAspectRatioPolicy;
+ private final DesktopAppCompatAspectRatioPolicy mDesktopAspectRatioPolicy;
@NonNull
private final AppCompatOverrides mAppCompatOverrides;
@NonNull
@@ -62,7 +62,7 @@ class AppCompatController {
wmService.mAppCompatConfiguration);
mAppCompatLetterboxPolicy = new AppCompatLetterboxPolicy(activityRecord,
wmService.mAppCompatConfiguration);
- mDesktopAppCompatAspectRatioPolicy = new DesktopAppCompatAspectRatioPolicy(activityRecord,
+ mDesktopAspectRatioPolicy = new DesktopAppCompatAspectRatioPolicy(activityRecord,
mAppCompatOverrides, mTransparentPolicy, wmService.mAppCompatConfiguration);
mSizeCompatModePolicy = new AppCompatSizeCompatModePolicy(activityRecord,
mAppCompatOverrides);
@@ -84,8 +84,8 @@ class AppCompatController {
}
@NonNull
- DesktopAppCompatAspectRatioPolicy getDesktopAppCompatAspectRatioPolicy() {
- return mDesktopAppCompatAspectRatioPolicy;
+ DesktopAppCompatAspectRatioPolicy getDesktopAspectRatioPolicy() {
+ return mDesktopAspectRatioPolicy;
}
@NonNull
diff --git a/services/core/java/com/android/server/wm/AppCompatUtils.java b/services/core/java/com/android/server/wm/AppCompatUtils.java
index d09f763e8b02..1ab0868b37d1 100644
--- a/services/core/java/com/android/server/wm/AppCompatUtils.java
+++ b/services/core/java/com/android/server/wm/AppCompatUtils.java
@@ -206,7 +206,7 @@ final class AppCompatUtils {
appCompatTaskInfo.cameraCompatTaskInfo.freeformCameraCompatMode =
AppCompatCameraPolicy.getCameraCompatFreeformMode(top);
appCompatTaskInfo.setHasMinAspectRatioOverride(top.mAppCompatController
- .getDesktopAppCompatAspectRatioPolicy().hasMinAspectRatioOverride(task));
+ .getDesktopAspectRatioPolicy().hasMinAspectRatioOverride(task));
}
/**
diff --git a/services/core/java/com/android/server/wm/DesktopModeBoundsCalculator.java b/services/core/java/com/android/server/wm/DesktopModeBoundsCalculator.java
index 65736b2c64c3..0106a64660fe 100644
--- a/services/core/java/com/android/server/wm/DesktopModeBoundsCalculator.java
+++ b/services/core/java/com/android/server/wm/DesktopModeBoundsCalculator.java
@@ -112,7 +112,7 @@ public final class DesktopModeBoundsCalculator {
return centerInScreen(idealSize, screenBounds);
}
final DesktopAppCompatAspectRatioPolicy desktopAppCompatAspectRatioPolicy =
- activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy();
+ activity.mAppCompatController.getDesktopAspectRatioPolicy();
float appAspectRatio = desktopAppCompatAspectRatioPolicy.calculateAspectRatio(task);
final float tdaWidth = stableBounds.width();
final float tdaHeight = stableBounds.height();
@@ -190,7 +190,7 @@ public final class DesktopModeBoundsCalculator {
@NonNull ActivityRecord activity, @NonNull Task task) {
final int activityOrientation = activity.getOverrideOrientation();
final DesktopAppCompatAspectRatioPolicy desktopAppCompatAspectRatioPolicy =
- activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy();
+ activity.mAppCompatController.getDesktopAspectRatioPolicy();
if (desktopAppCompatAspectRatioPolicy.shouldApplyUserMinAspectRatioOverride(task)
&& (!isFixedOrientation(activityOrientation)
|| activityOrientation == SCREEN_ORIENTATION_LOCKED)) {
diff --git a/services/tests/wmtests/src/com/android/server/wm/DesktopAppCompatAspectRatioPolicyTests.java b/services/tests/wmtests/src/com/android/server/wm/DesktopAppCompatAspectRatioPolicyTests.java
index 5e3b5affabb7..fa7dcc8ebbc7 100644
--- a/services/tests/wmtests/src/com/android/server/wm/DesktopAppCompatAspectRatioPolicyTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/DesktopAppCompatAspectRatioPolicyTests.java
@@ -408,7 +408,7 @@ public class DesktopAppCompatAspectRatioPolicyTests extends WindowTestsBase {
void onPostActivityCreation(@NonNull ActivityRecord activity) {
super.onPostActivityCreation(activity);
spyOn(activity.mAppCompatController.getAspectRatioOverrides());
- spyOn(activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy());
+ spyOn(activity.mAppCompatController.getDesktopAspectRatioPolicy());
}
void setDesiredAspectRatio(float aspectRatio) {
@@ -417,7 +417,7 @@ public class DesktopAppCompatAspectRatioPolicyTests extends WindowTestsBase {
}
DesktopAppCompatAspectRatioPolicy getDesktopAppCompatAspectRatioPolicy() {
- return getTopActivity().mAppCompatController.getDesktopAppCompatAspectRatioPolicy();
+ return getTopActivity().mAppCompatController.getDesktopAspectRatioPolicy();
}
float calculateAspectRatio() {
@@ -442,7 +442,7 @@ public class DesktopAppCompatAspectRatioPolicyTests extends WindowTestsBase {
void checkHasMinAspectRatioOverride(boolean expected) {
assertEquals(expected, this.activity().top().mAppCompatController
- .getDesktopAppCompatAspectRatioPolicy().hasMinAspectRatioOverride(
+ .getDesktopAspectRatioPolicy().hasMinAspectRatioOverride(
this.activity().top().getTask()));
}
diff --git a/services/tests/wmtests/src/com/android/server/wm/DesktopModeLaunchParamsModifierTests.java b/services/tests/wmtests/src/com/android/server/wm/DesktopModeLaunchParamsModifierTests.java
index 3de5d0c7727c..cdb51fc1c645 100644
--- a/services/tests/wmtests/src/com/android/server/wm/DesktopModeLaunchParamsModifierTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/DesktopModeLaunchParamsModifierTests.java
@@ -320,9 +320,9 @@ public class DesktopModeLaunchParamsModifierTests extends
final ActivityRecord activity = createActivity(display, SCREEN_ORIENTATION_PORTRAIT,
task, /* ignoreOrientationRequest */ true);
- spyOn(activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy());
+ spyOn(activity.mAppCompatController.getDesktopAspectRatioPolicy());
doReturn(LETTERBOX_ASPECT_RATIO).when(activity.mAppCompatController
- .getDesktopAppCompatAspectRatioPolicy()).calculateAspectRatio(any());
+ .getDesktopAspectRatioPolicy()).calculateAspectRatio(any());
final int desiredWidth =
(int) ((LANDSCAPE_DISPLAY_BOUNDS.height() / LETTERBOX_ASPECT_RATIO) + 0.5f);
@@ -812,9 +812,9 @@ public class DesktopModeLaunchParamsModifierTests extends
final ActivityRecord activity = createActivity(display, SCREEN_ORIENTATION_PORTRAIT,
task, /* ignoreOrientationRequest */ true);
- spyOn(activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy());
+ spyOn(activity.mAppCompatController.getDesktopAspectRatioPolicy());
doReturn(LETTERBOX_ASPECT_RATIO).when(activity.mAppCompatController
- .getDesktopAppCompatAspectRatioPolicy()).calculateAspectRatio(any());
+ .getDesktopAspectRatioPolicy()).calculateAspectRatio(any());
final int desiredHeight =
(int) (LANDSCAPE_DISPLAY_BOUNDS.height() * DESKTOP_MODE_INITIAL_BOUNDS_SCALE);
@@ -939,9 +939,9 @@ public class DesktopModeLaunchParamsModifierTests extends
final ActivityRecord activity = createActivity(display, SCREEN_ORIENTATION_LANDSCAPE,
task, /* ignoreOrientationRequest */ true);
- spyOn(activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy());
+ spyOn(activity.mAppCompatController.getDesktopAspectRatioPolicy());
doReturn(LETTERBOX_ASPECT_RATIO).when(activity.mAppCompatController
- .getDesktopAppCompatAspectRatioPolicy()).calculateAspectRatio(any());
+ .getDesktopAspectRatioPolicy()).calculateAspectRatio(any());
final int desiredWidth = PORTRAIT_DISPLAY_BOUNDS.width()
- (DESKTOP_MODE_LANDSCAPE_APP_PADDING * 2);
@@ -989,9 +989,9 @@ public class DesktopModeLaunchParamsModifierTests extends
final ActivityRecord activity = createActivity(display, SCREEN_ORIENTATION_LANDSCAPE,
task, /* ignoreOrientationRequest */ true);
- spyOn(activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy());
+ spyOn(activity.mAppCompatController.getDesktopAspectRatioPolicy());
doReturn(LETTERBOX_ASPECT_RATIO).when(activity.mAppCompatController
- .getDesktopAppCompatAspectRatioPolicy()).calculateAspectRatio(any());
+ .getDesktopAspectRatioPolicy()).calculateAspectRatio(any());
final int desiredWidth = PORTRAIT_DISPLAY_BOUNDS.width()
- (DESKTOP_MODE_LANDSCAPE_APP_PADDING * 2);
@@ -1294,7 +1294,7 @@ public class DesktopModeLaunchParamsModifierTests extends
private void setDesiredAspectRatio(ActivityRecord activity, float aspectRatio) {
final DesktopAppCompatAspectRatioPolicy desktopAppCompatAspectRatioPolicy =
- activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy();
+ activity.mAppCompatController.getDesktopAspectRatioPolicy();
spyOn(desktopAppCompatAspectRatioPolicy);
doReturn(aspectRatio).when(desktopAppCompatAspectRatioPolicy)
.getDesiredAspectRatio(any());
@@ -1304,7 +1304,7 @@ public class DesktopModeLaunchParamsModifierTests extends
float overrideValue) {
// Set desired aspect ratio to be below minimum so override can take effect.
final DesktopAppCompatAspectRatioPolicy desktopAppCompatAspectRatioPolicy =
- activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy();
+ activity.mAppCompatController.getDesktopAspectRatioPolicy();
spyOn(desktopAppCompatAspectRatioPolicy);
doReturn(1f).when(desktopAppCompatAspectRatioPolicy)
.getDesiredAspectRatio(any());
diff --git a/services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java b/services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java
index 3320db335d54..7683c66c18f3 100644
--- a/services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java
@@ -2416,7 +2416,7 @@ public class SizeCompatTests extends WindowTestsBase {
boolean enabled) {
final ActivityRecord activity = getActivityBuilderWithoutTask().build();
final DesktopAppCompatAspectRatioPolicy desktopAppCompatAspectRatioPolicy =
- activity.mAppCompatController.getDesktopAppCompatAspectRatioPolicy();
+ activity.mAppCompatController.getDesktopAspectRatioPolicy();
spyOn(desktopAppCompatAspectRatioPolicy);
doReturn(enabled).when(desktopAppCompatAspectRatioPolicy)
.hasMinAspectRatioOverride(any());