summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Fyodor Kupolov <fkupolov@google.com> 2018-01-05 02:10:46 +0000
committer android-build-merger <android-build-merger@google.com> 2018-01-05 02:10:46 +0000
commit28c72b43d9ef8cccd49d6f19b555506508c0f0ad (patch)
treea2ea799fc1981d5b2e29d5bd7194284261ea9b8f
parent3fcce9f251ef29dd25e01e46d09b684691c1a36a (diff)
parent130d5e391512a8a9b8e193357621116372a2e6a7 (diff)
Merge "Account: Fix the risk of sqliteconnection leak" am: 766f0a4981
am: 130d5e3915 Change-Id: I89eb0c20c06c7b077b59a4aa66b6693014192e43
-rw-r--r--services/core/java/com/android/server/accounts/AccountManagerService.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/services/core/java/com/android/server/accounts/AccountManagerService.java b/services/core/java/com/android/server/accounts/AccountManagerService.java
index 2fe8f2a1d428..6a6b5ce08f8b 100644
--- a/services/core/java/com/android/server/accounts/AccountManagerService.java
+++ b/services/core/java/com/android/server/accounts/AccountManagerService.java
@@ -2007,11 +2007,11 @@ public class AccountManagerService
getAccountRemovedReceivers(accountToRename, accounts);
accounts.accountsDb.beginTransaction();
Account renamedAccount = new Account(newName, accountToRename.type);
- if ((accounts.accountsDb.findCeAccountId(renamedAccount) >= 0)) {
- Log.e(TAG, "renameAccount failed - account with new name already exists");
- return null;
- }
try {
+ if ((accounts.accountsDb.findCeAccountId(renamedAccount) >= 0)) {
+ Log.e(TAG, "renameAccount failed - account with new name already exists");
+ return null;
+ }
final long accountId = accounts.accountsDb.findDeAccountId(accountToRename);
if (accountId >= 0) {
accounts.accountsDb.renameCeAccount(accountId, newName);