diff options
| author | 2015-04-16 16:57:05 +0000 | |
|---|---|---|
| committer | 2015-04-16 16:57:05 +0000 | |
| commit | 28a9089f5b79e20ca5b023830255cf438a9cded7 (patch) | |
| tree | dfa4efe79a64e2bb3e10a7d41759adc63b3fba8e | |
| parent | 2b300a99bbb133090b7ec39e64dd65ba2bb8f18d (diff) | |
| parent | 216d18b997eb929c2c3af9b2102595f4ec694c20 (diff) | |
am 216d18b9: Merge "Remove IV auto-generation workaround."
* commit '216d18b997eb929c2c3af9b2102595f4ec694c20':
Remove IV auto-generation workaround.
| -rw-r--r-- | keystore/java/android/security/KeyStoreCipherSpi.java | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/keystore/java/android/security/KeyStoreCipherSpi.java b/keystore/java/android/security/KeyStoreCipherSpi.java index 7bc637823c93..37e00b28cd83 100644 --- a/keystore/java/android/security/KeyStoreCipherSpi.java +++ b/keystore/java/android/security/KeyStoreCipherSpi.java @@ -547,18 +547,12 @@ public abstract class KeyStoreCipherSpi extends CipherSpi implements KeyStoreCry if (mIvRequired) { // IV is needed if ((mIv == null) && (mEncrypting)) { - // TODO: Switch to keymaster-generated IV code below once keymaster supports - // that. - // IV is needed but was not provided by the caller -- generate an IV. - mIv = new byte[mBlockSizeBytes]; - SecureRandom rng = (mRng != null) ? mRng : new SecureRandom(); - rng.nextBytes(mIv); -// // IV was not provided by the caller and thus will be generated by keymaster. -// // Mix in some additional entropy from the provided SecureRandom. -// if (mRng != null) { -// mAdditionalEntropyForBegin = new byte[mBlockSizeBytes]; -// mRng.nextBytes(mAdditionalEntropyForBegin); -// } + // IV was not provided by the caller and thus will be generated by keymaster. + // Mix in some additional entropy from the provided SecureRandom. + if (mRng != null) { + mAdditionalEntropyForBegin = new byte[mBlockSizeBytes]; + mRng.nextBytes(mAdditionalEntropyForBegin); + } } } } |