summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author RD Babiera <rdbabiera@google.com> 2023-03-09 22:07:44 +0000
committer RD Babiera <rdbabiera@google.com> 2023-03-09 22:07:44 +0000
commit286289695bd9f10e1961ff2230a3515ff5acb51e (patch)
tree1ca1cacba314045e3121fb595931d5ce4bf976bc
parent6f7a35628ea181146892fb37f09f67658e55135c (diff)
USB: remove empty stats logging for compliance warnings
Removes a call to FrameworkStatsLog.write when mUsbPortStatus is null or when compliance warnings array is empty. Test: atest CtsStatsdAtomHostTestCases:UsbStatsTests Bug: 269342794 Change-Id: I7f03b66c6c713d8b2afa7905a962a458cce285fe
-rw-r--r--services/usb/java/com/android/server/usb/UsbPortManager.java8
1 files changed, 3 insertions, 5 deletions
diff --git a/services/usb/java/com/android/server/usb/UsbPortManager.java b/services/usb/java/com/android/server/usb/UsbPortManager.java
index 1a1af3b929d1..2975e1e050f5 100644
--- a/services/usb/java/com/android/server/usb/UsbPortManager.java
+++ b/services/usb/java/com/android/server/usb/UsbPortManager.java
@@ -1362,12 +1362,10 @@ public class UsbPortManager implements IBinder.DeathRecipient {
}
}
- // Need to create new version to prevent double counting existing stats due
- // to new broadcast
private void logToStatsdComplianceWarnings(PortInfo portInfo) {
- if (portInfo.mUsbPortStatus == null) {
- FrameworkStatsLog.write(FrameworkStatsLog.USB_COMPLIANCE_WARNINGS_REPORTED,
- portInfo.mUsbPort.getId(), new int[0]);
+ // Don't report if there isn't anything to report
+ if (portInfo.mUsbPortStatus == null
+ || portInfo.mUsbPortStatus.getComplianceWarnings().length == 0) {
return;
}