diff options
| author | 2023-11-20 15:10:10 +0000 | |
|---|---|---|
| committer | 2023-12-04 16:56:03 +0000 | |
| commit | 2807c901369fbd0f048ba5646a65e921e39f2ef4 (patch) | |
| tree | ed47bfbbcc888e6e0a563563d5782ecd7ec98ea4 | |
| parent | 7812cce9adbe283cf84b18584fdd52eb4d703958 (diff) | |
Migrate multi crop flag
Flag: ACONFIG com.android.window.flags.multi_crop DEVELOPMENT
Bug: 281648899
Test: treehugger
Change-Id: Ib023aacb9ced7d551cc025b38be81a5b6097c9f8
4 files changed, 13 insertions, 12 deletions
diff --git a/core/java/android/app/WallpaperManager.java b/core/java/android/app/WallpaperManager.java index d660078a9ae7..820ff3e308e4 100644 --- a/core/java/android/app/WallpaperManager.java +++ b/core/java/android/app/WallpaperManager.java @@ -21,6 +21,8 @@ import static android.Manifest.permission.READ_WALLPAPER_INTERNAL; import static android.content.pm.PackageManager.PERMISSION_GRANTED; import static android.os.ParcelFileDescriptor.MODE_READ_ONLY; +import static com.android.window.flags.Flags.multiCrop; + import android.annotation.FloatRange; import android.annotation.IntDef; import android.annotation.NonNull; @@ -857,8 +859,7 @@ public class WallpaperManager { */ public static boolean isMultiCropEnabled() { if (sGlobals == null) { - sIsMultiCropEnabled = SystemProperties.getBoolean( - "persist.wm.debug.wallpaper_multi_crop", false); + sIsMultiCropEnabled = multiCrop(); } if (sIsMultiCropEnabled == null) { try { diff --git a/core/java/android/window/flags/wallpaper_manager.aconfig b/core/java/android/window/flags/wallpaper_manager.aconfig index 09be0cfc5fb0..f03c993a9c66 100644 --- a/core/java/android/window/flags/wallpaper_manager.aconfig +++ b/core/java/android/window/flags/wallpaper_manager.aconfig @@ -5,4 +5,11 @@ flag { namespace: "wear_frameworks" description: "Allow out of focus process to update wallpaper complications" bug: "271132915" -}
\ No newline at end of file +} + +flag { + name: "multi_crop" + namespace: "systemui" + description: "Support storing different wallpaper crops for different display dimensions. Only effective after rebooting." + bug: "281648899" +} diff --git a/packages/SystemUI/src/com/android/systemui/flags/Flags.kt b/packages/SystemUI/src/com/android/systemui/flags/Flags.kt index 7cb2c6e1fcff..ab030bf66ed6 100644 --- a/packages/SystemUI/src/com/android/systemui/flags/Flags.kt +++ b/packages/SystemUI/src/com/android/systemui/flags/Flags.kt @@ -443,12 +443,6 @@ object Flags { val LOCKSCREEN_ENABLE_LANDSCAPE = unreleasedFlag("lockscreen.enable_landscape") - // TODO(b/281648899): Tracking bug - @Keep - @JvmField - val WALLPAPER_MULTI_CROP = - sysPropBooleanFlag("persist.wm.debug.wallpaper_multi_crop", default = false) - // 1200 - predictive back @Keep @JvmField diff --git a/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java b/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java index e088d9afd67d..1485b961789c 100644 --- a/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java +++ b/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java @@ -40,6 +40,7 @@ import static com.android.server.wallpaper.WallpaperUtils.WALLPAPER_INFO; import static com.android.server.wallpaper.WallpaperUtils.WALLPAPER_LOCK_ORIG; import static com.android.server.wallpaper.WallpaperUtils.getWallpaperDir; import static com.android.server.wallpaper.WallpaperUtils.makeWallpaperIdLocked; +import static com.android.window.flags.Flags.multiCrop; import android.annotation.NonNull; import android.app.ActivityManager; @@ -93,7 +94,6 @@ import android.os.ResultReceiver; import android.os.SELinux; import android.os.ShellCallback; import android.os.SystemClock; -import android.os.SystemProperties; import android.os.UserHandle; import android.os.UserManager; import android.os.storage.StorageManager; @@ -1516,8 +1516,7 @@ public class WallpaperManagerService extends IWallpaperManager.Stub mColorsChangedListeners = new SparseArray<>(); mWallpaperDataParser = new WallpaperDataParser(mContext, mWallpaperDisplayHelper, mWallpaperCropper); - mIsMultiCropEnabled = - SystemProperties.getBoolean("persist.wm.debug.wallpaper_multi_crop", false); + mIsMultiCropEnabled = multiCrop(); LocalServices.addService(WallpaperManagerInternal.class, new LocalService()); } |