summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Anton Hansson <hansson@google.com> 2019-02-06 12:14:12 +0000
committer Anton Hansson <hansson@google.com> 2019-02-06 12:26:30 +0000
commit2579d1a48faf3c45f14c29b1388f44bf0d8a4ee6 (patch)
treee4029608bab4c2d49ce79b519791289f6cd51663
parent61962c97efbfc5ceb0d12c34ab72a569cffb4c5f (diff)
Remove empty default constructor
Unused. Initially added to ease mocking/inheritance for testing purposes, but apparently not necessary because a package-private default constructor is auto-generated. Also make fields final. Bug: 123600502 Test: atest cts/tests/tests/os/src/android/os/cts/BuildVersionTest.java Change-Id: I123a19fd0760259db67344bb827c0cf2de3b85c3
-rw-r--r--api/current.txt1
-rwxr-xr-xcore/java/android/os/Build.java8
2 files changed, 3 insertions, 6 deletions
diff --git a/api/current.txt b/api/current.txt
index ad321c6288b3..55025e7d0661 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -34199,7 +34199,6 @@ package android.os {
}
public static class Build.Partition {
- ctor public Build.Partition();
method public long getBuildTimeMillis();
method @NonNull public String getFingerprint();
method @NonNull public String getName();
diff --git a/core/java/android/os/Build.java b/core/java/android/os/Build.java
index 2d61a4ee95d9..83a7654d494b 100755
--- a/core/java/android/os/Build.java
+++ b/core/java/android/os/Build.java
@@ -1120,11 +1120,9 @@ public class Build {
/** The name identifying the system partition. */
public static final String PARTITION_NAME_SYSTEM = "system";
- private String mName;
- private String mFingerprint;
- private long mTimeMs;
-
- public Partition() {}
+ private final String mName;
+ private final String mFingerprint;
+ private final long mTimeMs;
private Partition(String name, String fingerprint, long timeMs) {
mName = name;