diff options
| author | 2021-04-19 10:55:33 +0000 | |
|---|---|---|
| committer | 2021-04-19 10:55:33 +0000 | |
| commit | 24f475b502a9f2d4774d8f1fe06052e1d37f806c (patch) | |
| tree | e37c94f263043f477b5726c68ffa6a9178e23a1f | |
| parent | 29f7ff1aa62f515b2d86fdbb85cefa178e8a2e1b (diff) | |
| parent | 8380a16e8e7cc651eb1965cebbaf54887f034309 (diff) | |
Merge "CEC: Drop TODOs marked as fixed/obsolete" am: 6e7f16ac1e am: 59cb50e06a am: 8380a16e8e
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1676434
Change-Id: I8cfd3fc1e3287ec2cef799d008dc5bcbcc1881a9
5 files changed, 8 insertions, 18 deletions
diff --git a/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java b/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java index bdd5ab67af48..e7d76f66230d 100644 --- a/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java +++ b/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java @@ -63,7 +63,6 @@ public final class HdmiAudioSystemClient extends HdmiClient { * * @hide */ - // TODO(b/110094868): unhide and add @SystemApi for Q public interface SetSystemAudioModeCallback { /** * Called when the input was changed. @@ -74,7 +73,6 @@ public final class HdmiAudioSystemClient extends HdmiClient { } /** @hide */ - // TODO(b/110094868): unhide and add @SystemApi for Q @Override public int getDeviceType() { return HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM; @@ -143,7 +141,6 @@ public final class HdmiAudioSystemClient extends HdmiClient { * * @hide */ - // TODO(b/110094868): unhide and add @SystemApi for Q public void setSystemAudioMode(boolean state, @NonNull SetSystemAudioModeCallback callback) { // TODO(amyjojo): implement this when needed. } @@ -156,7 +153,6 @@ public final class HdmiAudioSystemClient extends HdmiClient { * * @hide */ - // TODO(b/110094868): unhide and add @SystemApi for Q public void setSystemAudioModeOnForAudioOnlySource() { try { mService.setSystemAudioModeOnForAudioOnlySource(); diff --git a/core/java/android/hardware/hdmi/HdmiClient.java b/core/java/android/hardware/hdmi/HdmiClient.java index a921215c6133..0c21746ea412 100644 --- a/core/java/android/hardware/hdmi/HdmiClient.java +++ b/core/java/android/hardware/hdmi/HdmiClient.java @@ -65,7 +65,6 @@ public abstract class HdmiClient { * @param isPressed true if this is key press event * * @hide - * TODO(b/110094868): unhide for Q */ public void sendVolumeKeyEvent(int keyCode, boolean isPressed) { try { diff --git a/core/java/android/hardware/hdmi/HdmiControlManager.java b/core/java/android/hardware/hdmi/HdmiControlManager.java index ad71f15f6e26..6079c57e429a 100644 --- a/core/java/android/hardware/hdmi/HdmiControlManager.java +++ b/core/java/android/hardware/hdmi/HdmiControlManager.java @@ -1009,7 +1009,6 @@ public final class HdmiControlManager { * * @return {@link HdmiAudioSystemClient} instance. {@code null} on failure. * - * TODO(b/110094868): unhide for Q * @hide */ @Nullable diff --git a/core/java/android/hardware/hdmi/HdmiUtils.java b/core/java/android/hardware/hdmi/HdmiUtils.java index 8c94b7841a80..2f4378ebed9d 100644 --- a/core/java/android/hardware/hdmi/HdmiUtils.java +++ b/core/java/android/hardware/hdmi/HdmiUtils.java @@ -24,7 +24,6 @@ import java.lang.annotation.RetentionPolicy; /** * Various utilities related to HDMI CEC. * - * TODO(b/110094868): unhide for Q * @hide */ public final class HdmiUtils { @@ -84,7 +83,6 @@ public final class HdmiUtils { } /** - * TODO(b/110094868): unhide for Q * @hide */ @Retention(RetentionPolicy.SOURCE) @@ -95,49 +93,49 @@ public final class HdmiUtils { public @interface HdmiAddressRelativePosition {} /** * HDMI relative position is not determined. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_UNKNOWN = 0; /** * HDMI relative position: directly blow the device. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_DIRECTLY_BELOW = 1; /** * HDMI relative position: indirectly below the device. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_BELOW = 2; /** * HDMI relative position: the same device. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_SAME = 3; /** * HDMI relative position: directly above the device. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_DIRECTLY_ABOVE = 4; /** * HDMI relative position: indirectly above the device. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_ABOVE = 5; /** * HDMI relative position: directly below a same device. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_SIBLING = 6; /** * HDMI relative position: different branch. - * TODO(b/110094868): unhide for Q + * * @hide */ public static final int HDMI_RELATIVE_POSITION_DIFFERENT_BRANCH = 7; diff --git a/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java b/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java index 3678b198d6e5..6114094f2dce 100644 --- a/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java +++ b/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java @@ -222,7 +222,6 @@ public class HdmiCecLocalDeviceAudioSystem extends HdmiCecLocalDeviceSource { super.disableDevice(initiatedByCec, callback); assertRunOnServiceThread(); mService.unregisterTvInputCallback(mTvInputCallback); - // TODO(b/129088603): check disableDevice and onStandby behaviors per spec } @Override @@ -847,7 +846,6 @@ public class HdmiCecLocalDeviceAudioSystem extends HdmiCecLocalDeviceSource { } protected void switchToAudioInput() { - // TODO(b/111396634): switch input according to PROPERTY_SYSTEM_AUDIO_MODE_AUDIO_PORT } protected boolean isDirectConnectToTv() { |