diff options
author | 2019-02-28 17:38:07 -0500 | |
---|---|---|
committer | 2019-02-28 18:26:07 -0500 | |
commit | 24192c806a908865d01d38365c1a6680f22e2824 (patch) | |
tree | b46b462fae2cacc0ab31ffa1a37bc04ae8c50e6b | |
parent | b10113347d1c008a3ccbb02b86722a6c02ab0e18 (diff) |
Add nullability annotations to ColorStateListDrawable
Test: Annotation-only change, exsiting tests still pass
Change-Id: I34d56679658045aa57b93cfd6ad77b2859ce224a
Fix: 126701617
Fix: 126701492
-rw-r--r-- | api/current.txt | 14 | ||||
-rw-r--r-- | graphics/java/android/graphics/drawable/ColorStateListDrawable.java | 29 |
2 files changed, 22 insertions, 21 deletions
diff --git a/api/current.txt b/api/current.txt index 968811d85d31..30fa650a88c4 100644 --- a/api/current.txt +++ b/api/current.txt @@ -15273,18 +15273,18 @@ package android.graphics.drawable { public class ColorStateListDrawable extends android.graphics.drawable.Drawable implements android.graphics.drawable.Drawable.Callback { ctor public ColorStateListDrawable(); - ctor public ColorStateListDrawable(android.content.res.ColorStateList); + ctor public ColorStateListDrawable(@NonNull android.content.res.ColorStateList); method public void clearAlpha(); - method public void draw(android.graphics.Canvas); + method public void draw(@NonNull android.graphics.Canvas); method @NonNull public android.content.res.ColorStateList getColorStateList(); method public int getOpacity(); method public boolean hasFocusStateSpecified(); - method public void invalidateDrawable(android.graphics.drawable.Drawable); - method public void scheduleDrawable(android.graphics.drawable.Drawable, Runnable, long); + method public void invalidateDrawable(@NonNull android.graphics.drawable.Drawable); + method public void scheduleDrawable(@NonNull android.graphics.drawable.Drawable, @NonNull Runnable, long); method public void setAlpha(@IntRange(from=0, to=255) int); - method public void setColorFilter(android.graphics.ColorFilter); - method public void setColorStateList(android.content.res.ColorStateList); - method public void unscheduleDrawable(android.graphics.drawable.Drawable, Runnable); + method public void setColorFilter(@Nullable android.graphics.ColorFilter); + method public void setColorStateList(@NonNull android.content.res.ColorStateList); + method public void unscheduleDrawable(@NonNull android.graphics.drawable.Drawable, @NonNull Runnable); } public abstract class Drawable { diff --git a/graphics/java/android/graphics/drawable/ColorStateListDrawable.java b/graphics/java/android/graphics/drawable/ColorStateListDrawable.java index 5181d8992be5..ee4d1e72c130 100644 --- a/graphics/java/android/graphics/drawable/ColorStateListDrawable.java +++ b/graphics/java/android/graphics/drawable/ColorStateListDrawable.java @@ -17,6 +17,7 @@ package android.graphics.drawable; import android.annotation.IntRange; import android.annotation.NonNull; +import android.annotation.Nullable; import android.content.pm.ActivityInfo; import android.content.res.ColorStateList; import android.content.res.Resources; @@ -40,14 +41,14 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac initializeColorDrawable(); } - public ColorStateListDrawable(ColorStateList colorStateList) { + public ColorStateListDrawable(@NonNull ColorStateList colorStateList) { mState = new ColorStateListDrawableState(); initializeColorDrawable(); setColorStateList(colorStateList); } @Override - public void draw(Canvas canvas) { + public void draw(@NonNull Canvas canvas) { mColorDrawable.draw(canvas); } @@ -73,7 +74,7 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac } @Override - public void applyTheme(Resources.Theme t) { + public void applyTheme(@NonNull Resources.Theme t) { super.applyTheme(t); if (mState.mColor != null) { @@ -106,26 +107,26 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac } @Override - public void setTintList(ColorStateList tint) { + public void setTintList(@Nullable ColorStateList tint) { mState.mTint = tint; mColorDrawable.setTintList(tint); onStateChange(getState()); } @Override - public void setTintMode(PorterDuff.Mode tintMode) { + public void setTintMode(@NonNull PorterDuff.Mode tintMode) { mState.mTintMode = tintMode; mColorDrawable.setTintMode(tintMode); onStateChange(getState()); } @Override - public ColorFilter getColorFilter() { + public @Nullable ColorFilter getColorFilter() { return mColorDrawable.getColorFilter(); } @Override - public void setColorFilter(ColorFilter colorFilter) { + public void setColorFilter(@Nullable ColorFilter colorFilter) { mColorDrawable.setColorFilter(colorFilter); } @@ -156,28 +157,28 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac } @Override - public void invalidateDrawable(Drawable who) { + public void invalidateDrawable(@NonNull Drawable who) { if (who == mColorDrawable && getCallback() != null) { getCallback().invalidateDrawable(this); } } @Override - public void scheduleDrawable(Drawable who, Runnable what, long when) { + public void scheduleDrawable(@NonNull Drawable who, @NonNull Runnable what, long when) { if (who == mColorDrawable && getCallback() != null) { getCallback().scheduleDrawable(this, what, when); } } @Override - public void unscheduleDrawable(Drawable who, Runnable what) { + public void unscheduleDrawable(@NonNull Drawable who, @NonNull Runnable what) { if (who == mColorDrawable && getCallback() != null) { getCallback().unscheduleDrawable(this, what); } } @Override - public ConstantState getConstantState() { + public @NonNull ConstantState getConstantState() { mState.mChangingConfigurations = mState.mChangingConfigurations | (getChangingConfigurations() & ~mState.getChangingConfigurations()); return mState; @@ -203,7 +204,7 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac } @Override - public Drawable mutate() { + public @NonNull Drawable mutate() { if (!mMutated && super.mutate() == this) { mState = new ColorStateListDrawableState(mState); mMutated = true; @@ -226,7 +227,7 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac * * @param colorStateList A color state list to attach. */ - public void setColorStateList(ColorStateList colorStateList) { + public void setColorStateList(@NonNull ColorStateList colorStateList) { mState.mColor = colorStateList; onStateChange(getState()); } @@ -278,7 +279,7 @@ public class ColorStateListDrawable extends Drawable implements Drawable.Callbac } } - private ColorStateListDrawable(ColorStateListDrawableState state) { + private ColorStateListDrawable(@NonNull ColorStateListDrawableState state) { mState = state; initializeColorDrawable(); } |