summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Phil Burk <philburk@google.com> 2022-01-24 16:56:41 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2022-01-24 16:56:41 +0000
commit230b32ceb6c143eed852d298dfbb3bdd3a801adc (patch)
tree43f45e403217d2ec7c78362f20eb5f33c4d43dc9
parent71cadb9480a3926f3304e19e16cbb62f1bb537b9 (diff)
parent5438955940a90d3aa3daf48a13740b3e0b59fd6a (diff)
Merge "MidiService: check UID in getDeviceStatus()"
-rw-r--r--services/midi/java/com/android/server/midi/MidiService.java10
1 files changed, 9 insertions, 1 deletions
diff --git a/services/midi/java/com/android/server/midi/MidiService.java b/services/midi/java/com/android/server/midi/MidiService.java
index 6e724792b6e9..d56278629bf2 100644
--- a/services/midi/java/com/android/server/midi/MidiService.java
+++ b/services/midi/java/com/android/server/midi/MidiService.java
@@ -864,7 +864,15 @@ public class MidiService extends IMidiManager.Stub {
if (device == null) {
throw new IllegalArgumentException("no such device for " + deviceInfo);
}
- return device.getDeviceStatus();
+ int uid = Binder.getCallingUid();
+ if (device.isUidAllowed(uid)) {
+ return device.getDeviceStatus();
+ } else {
+ Log.e(TAG, "getDeviceStatus() invalid UID = " + uid);
+ EventLog.writeEvent(0x534e4554, "203549963",
+ uid, "getDeviceStatus: invalid uid");
+ return null;
+ }
}
@Override