summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Alex Klyubin <klyubin@google.com> 2015-04-16 17:07:47 +0000
committer Android Git Automerger <android-git-automerger@android.com> 2015-04-16 17:07:47 +0000
commit22b5d9b969176a196b0b29ce9441ac3d1d35d208 (patch)
treef4ffa1a488b9132ccbbae0d42f08c73c53a0875a
parent133911095ce0d9ef01766aa7b67a0a31b852e242 (diff)
parent28a9089f5b79e20ca5b023830255cf438a9cded7 (diff)
am 28a9089f: am 216d18b9: Merge "Remove IV auto-generation workaround."
* commit '28a9089f5b79e20ca5b023830255cf438a9cded7': Remove IV auto-generation workaround.
-rw-r--r--keystore/java/android/security/KeyStoreCipherSpi.java18
1 files changed, 6 insertions, 12 deletions
diff --git a/keystore/java/android/security/KeyStoreCipherSpi.java b/keystore/java/android/security/KeyStoreCipherSpi.java
index 7bc637823c93..37e00b28cd83 100644
--- a/keystore/java/android/security/KeyStoreCipherSpi.java
+++ b/keystore/java/android/security/KeyStoreCipherSpi.java
@@ -547,18 +547,12 @@ public abstract class KeyStoreCipherSpi extends CipherSpi implements KeyStoreCry
if (mIvRequired) {
// IV is needed
if ((mIv == null) && (mEncrypting)) {
- // TODO: Switch to keymaster-generated IV code below once keymaster supports
- // that.
- // IV is needed but was not provided by the caller -- generate an IV.
- mIv = new byte[mBlockSizeBytes];
- SecureRandom rng = (mRng != null) ? mRng : new SecureRandom();
- rng.nextBytes(mIv);
-// // IV was not provided by the caller and thus will be generated by keymaster.
-// // Mix in some additional entropy from the provided SecureRandom.
-// if (mRng != null) {
-// mAdditionalEntropyForBegin = new byte[mBlockSizeBytes];
-// mRng.nextBytes(mAdditionalEntropyForBegin);
-// }
+ // IV was not provided by the caller and thus will be generated by keymaster.
+ // Mix in some additional entropy from the provided SecureRandom.
+ if (mRng != null) {
+ mAdditionalEntropyForBegin = new byte[mBlockSizeBytes];
+ mRng.nextBytes(mAdditionalEntropyForBegin);
+ }
}
}
}