summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Mathias Agopian <mathias@google.com> 2011-11-16 21:00:52 -0800
committer Android Git Automerger <android-git-automerger@android.com> 2011-11-16 21:00:52 -0800
commit2030d78dc9c20d2f561f4b11f1a1adddb63661c6 (patch)
tree69a50afd09c7dde537e28dd084d9bb0af3e22956
parente788fa84f1fac845e50922fc536694ce1cc2fbdb (diff)
parent8fc3540fdf759ff3bb03b00e81d94d6c4102d530 (diff)
am 8fc3540f: Merge "be a bit more defensive when parsing extension strings" into ics-mr1
* commit '8fc3540fdf759ff3bb03b00e81d94d6c4102d530': be a bit more defensive when parsing extension strings
-rw-r--r--opengl/libs/EGL/egl_display.cpp22
1 files changed, 13 insertions, 9 deletions
diff --git a/opengl/libs/EGL/egl_display.cpp b/opengl/libs/EGL/egl_display.cpp
index 862b48d22cbd..31119f9608d5 100644
--- a/opengl/libs/EGL/egl_display.cpp
+++ b/opengl/libs/EGL/egl_display.cpp
@@ -220,15 +220,19 @@ EGLBoolean egl_display_t::initialize(EGLint *major, EGLint *minor) {
if (end) {
// length of the extension string
const size_t len = end - start;
- // NOTE: we could avoid the copy if we had strnstr.
- const String8 ext(start, len);
- // now go through all implementations and look for this extension
- for (int i = 0; i < IMPL_NUM_IMPLEMENTATIONS; i++) {
- // if we find it, add this extension string to our list
- // (and don't forget the space)
- const char* match = strstr(disp[i].queryString.extensions, ext.string());
- if (match && (match[len] == ' ' || match[len] == 0)) {
- mExtensionString.append(start, len+1);
+ if (len) {
+ // NOTE: we could avoid the copy if we had strnstr.
+ const String8 ext(start, len);
+ // now go through all implementations and look for this extension
+ for (int i = 0; i < IMPL_NUM_IMPLEMENTATIONS; i++) {
+ if (disp[i].queryString.extensions) {
+ // if we find it, add this extension string to our list
+ // (and don't forget the space)
+ const char* match = strstr(disp[i].queryString.extensions, ext.string());
+ if (match && (match[len] == ' ' || match[len] == 0)) {
+ mExtensionString.append(start, len+1);
+ }
+ }
}
}
// process the next extension string, and skip the space.