summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Song Chun Fan <schfan@google.com> 2025-03-05 09:46:40 -0800
committer Song Chun Fan <schfan@google.com> 2025-03-05 09:46:40 -0800
commit1fb50fdc023867f3825263bb0787df80f07b5d56 (patch)
treecc3d533b0a84ab64b36d543e01a92f38db019efa
parent1d909ba98c1bbda8bed88ba61478bf1ee38f02be (diff)
[pm] clean up getRealPackageSetting
It is no longer used and was always a source of confusion. BUG: 321139675 Test: builds FLAG: EXEMPT clean up Change-Id: I5081e1e747bbc6aa9353873cb2ec4a69dcf4464f
-rw-r--r--services/core/java/com/android/server/pm/InstallRequest.java14
1 files changed, 0 insertions, 14 deletions
diff --git a/services/core/java/com/android/server/pm/InstallRequest.java b/services/core/java/com/android/server/pm/InstallRequest.java
index 734920435e26..3361dbc2df07 100644
--- a/services/core/java/com/android/server/pm/InstallRequest.java
+++ b/services/core/java/com/android/server/pm/InstallRequest.java
@@ -644,20 +644,6 @@ final class InstallRequest {
return mScanResult.mPkgSetting;
}
- @Nullable
- public PackageSetting getRealPackageSetting() {
- // TODO: Fix this to have 1 mutable PackageSetting for scan/install. If the previous
- // setting needs to be passed to have a comparison, hide it behind an immutable
- // interface. There's no good reason to have 3 different ways to access the real
- // PackageSetting object, only one of which is actually correct.
- PackageSetting realPkgSetting = isExistingSettingCopied()
- ? getScanRequestPackageSetting() : getScannedPackageSetting();
- if (realPkgSetting == null) {
- realPkgSetting = getScannedPackageSetting();
- }
- return realPkgSetting;
- }
-
public boolean isExistingSettingCopied() {
assertScanResultExists();
return mScanResult.mExistingSettingCopied;