diff options
| author | 2019-08-15 13:27:46 -0700 | |
|---|---|---|
| committer | 2019-08-22 21:41:11 +0000 | |
| commit | 1fa946a2f285283277d75bf741bfef05f6bc9d8e (patch) | |
| tree | 1c72d4f0597c2e8bd209734bc421c4a2c2b416db | |
| parent | a0914d81ef9f4d7258f1530dc3bfdd575f6e448d (diff) | |
Fix android-cloexec-pipe clang-tidy warning
The upcoming clang-tidy update finds a new instance of
android-cloexec-pipe warning:
FileUtilsTests.cpp:72:13: error: prefer pipe2() with O_CLOEXEC to avoid leaking file descriptors to child processes
ASSERT_EQ(pipe(pipefd), 0);
^~~~~~~~~~~~
pipe2(pipefd, O_CLOEXEC)
Apply the suggested fix by clang-tidy.
Test: build
Bug: 131328001
Exempt-From-Owner-Approval: Cherrypick
Change-Id: Iee772b5c3ed5e2af481e479dab19030f8419290a
Merged-In: Iee772b5c3ed5e2af481e479dab19030f8419290a
(cherry picked from commit f61e2167d5352b63eb34a086cdcb0dfec485bdf0)
| -rw-r--r-- | cmds/idmap2/tests/FileUtilsTests.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/cmds/idmap2/tests/FileUtilsTests.cpp b/cmds/idmap2/tests/FileUtilsTests.cpp index f4a306e41e32..f55acee029dc 100644 --- a/cmds/idmap2/tests/FileUtilsTests.cpp +++ b/cmds/idmap2/tests/FileUtilsTests.cpp @@ -15,6 +15,7 @@ */ #include <dirent.h> +#include <fcntl.h> #include <set> #include <string> @@ -69,7 +70,7 @@ TEST(FileUtilsTests, FindFilesFindApkFilesRecursive) { TEST(FileUtilsTests, ReadFile) { int pipefd[2]; - ASSERT_EQ(pipe(pipefd), 0); + ASSERT_EQ(pipe2(pipefd, O_CLOEXEC), 0); ASSERT_EQ(write(pipefd[1], "foobar", 6), 6); close(pipefd[1]); |