summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Marco Nelissen <marcone@google.com> 2016-09-08 17:34:16 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2016-09-08 17:34:19 +0000
commit1f65a69d9ab9e8f5ee4eb8ec49f70d5107de5b26 (patch)
tree5a963483020b26d399f18b4118e143e3cf7dd0b0
parent466d359330f6edb02421ea1f4f6849e9e97db7d9 (diff)
parent439e5e49fb3278662889d057e578f2e08f347ad5 (diff)
Merge "Fix memory leak in MediaScannerConnection" into nyc-mr1-dev
-rw-r--r--media/java/android/media/MediaScannerConnection.java5
1 files changed, 5 insertions, 0 deletions
diff --git a/media/java/android/media/MediaScannerConnection.java b/media/java/android/media/MediaScannerConnection.java
index d71467255ff3..471fa2c4bad9 100644
--- a/media/java/android/media/MediaScannerConnection.java
+++ b/media/java/android/media/MediaScannerConnection.java
@@ -133,6 +133,10 @@ public class MediaScannerConnection implements ServiceConnection {
}
try {
mContext.unbindService(this);
+ if (mClient instanceof ClientProxy) {
+ mClient = null;
+ }
+ mService = null;
} catch (IllegalArgumentException ex) {
if (false) {
Log.v(TAG, "disconnect failed: " + ex);
@@ -205,6 +209,7 @@ public class MediaScannerConnection implements ServiceConnection {
void scanNextPath() {
if (mNextPath >= mPaths.length) {
mConnection.disconnect();
+ mConnection = null;
return;
}
String mimeType = mMimeTypes != null ? mMimeTypes[mNextPath] : null;