summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Ben Kwa <kenobi@google.com> 2015-09-09 13:49:07 -0700
committer Ben Kwa <kenobi@google.com> 2015-09-09 13:49:07 -0700
commit1f051b18eb1cf53f67e3fdcedcaf61342463a3bc (patch)
tree6482a0a45a04d3744976fb09d55b0bf3cc416b69
parent55a309f8e2a972a2f0ef0cd86736d3c2f47a75f6 (diff)
Fix a crash during file deletion.
Fix an off-by-one error when checking deletion candidates, that was causing item positions to be incorrectly bumped following a successful deletion. BUG=23823860 Change-Id: Id261ad49271fb0c1a5ff1cba88fea1451412d7f3
-rw-r--r--packages/DocumentsUI/src/com/android/documentsui/DirectoryFragment.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/packages/DocumentsUI/src/com/android/documentsui/DirectoryFragment.java b/packages/DocumentsUI/src/com/android/documentsui/DirectoryFragment.java
index edf829d178c9..253a4af82aa7 100644
--- a/packages/DocumentsUI/src/com/android/documentsui/DirectoryFragment.java
+++ b/packages/DocumentsUI/src/com/android/documentsui/DirectoryFragment.java
@@ -1824,7 +1824,7 @@ public class DirectoryFragment extends Fragment {
// position by 1.
final int originalPos = position;
final int size = mMarkedForDeletion.size();
- for (int i = 0; i <= size; ++i) {
+ for (int i = 0; i < size; ++i) {
// It'd be more concise, but less efficient, to iterate over positions while calling
// mMarkedForDeletion.get. Instead, iterate over deleted entries.
if (mMarkedForDeletion.keyAt(i) <= position && mMarkedForDeletion.valueAt(i)) {