summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Will Leshner <wleshner@google.com> 2024-08-05 14:54:08 -0700
committer Will Leshner <wleshner@google.com> 2024-08-05 14:56:42 -0700
commit1f00a70a55f8d64b77d887cbaabfeb5e2892dfd5 (patch)
tree6d0f2a89302437615dc6a36fc10ffb4b98c78ef9
parent1573d2095b0c173418e42e0b5b54ba02b7852ecc (diff)
Fix a bug with showing the widget picker on edit activity launch.
Delaying showing the widget picker until after the edit activity has appeared avoids an issue with transitions that results in the edit activity being closed prematurely. Bug: 357150334 Test: manually Flag: EXEMPT bugfix Change-Id: I2c7dbeb8fb330f29c72c0e6d31fa5611e6c927c2
-rw-r--r--packages/SystemUI/src/com/android/systemui/communal/widgets/EditWidgetsActivity.kt12
1 files changed, 7 insertions, 5 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/communal/widgets/EditWidgetsActivity.kt b/packages/SystemUI/src/com/android/systemui/communal/widgets/EditWidgetsActivity.kt
index 03ef17b6ec5b..948f4cda7c59 100644
--- a/packages/SystemUI/src/com/android/systemui/communal/widgets/EditWidgetsActivity.kt
+++ b/packages/SystemUI/src/com/android/systemui/communal/widgets/EditWidgetsActivity.kt
@@ -154,6 +154,13 @@ constructor(
// edit mode
communalViewModel.currentScene.first { it == CommunalScenes.Blank }
communalViewModel.setEditModeState(EditModeState.SHOWING)
+
+ // Show the widget picker, if necessary, after the edit activity has animated in.
+ // Waiting until after the activity has appeared avoids transitions issues.
+ if (shouldOpenWidgetPickerOnStart) {
+ onOpenWidgetPicker()
+ shouldOpenWidgetPickerOnStart = false
+ }
}
}
}
@@ -198,11 +205,6 @@ constructor(
communalViewModel.setEditActivityShowing(true)
- if (shouldOpenWidgetPickerOnStart) {
- onOpenWidgetPicker()
- shouldOpenWidgetPickerOnStart = false
- }
-
logger.i("Starting the communal widget editor activity")
uiEventLogger.log(CommunalUiEvent.COMMUNAL_HUB_EDIT_MODE_SHOWN)
}