diff options
author | 2020-10-23 21:18:47 +0000 | |
---|---|---|
committer | 2020-10-23 21:18:47 +0000 | |
commit | 1e3cd9a07dcb79116f6eaa8acdf76cf9a356416d (patch) | |
tree | e786b84e8c027ca0df2d123960e082fbf30116ed | |
parent | b94d36d4c76cbcbaf860b0d25d07c90afb119421 (diff) | |
parent | 54f0682ff06235a02d01c7af521419f3aa78b93b (diff) |
Merge "Temporarily disable some Bubbles checks"
2 files changed, 6 insertions, 4 deletions
diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java index da623aed4dd5..8ea432634e61 100755 --- a/services/core/java/com/android/server/notification/NotificationManagerService.java +++ b/services/core/java/com/android/server/notification/NotificationManagerService.java @@ -6097,14 +6097,15 @@ public class NotificationManagerService extends SystemService { } // bubble or inline reply that's immutable? - if (n.getBubbleMetadata() != null + // TODO (b/171418004): renable after app outreach + /*if (n.getBubbleMetadata() != null && n.getBubbleMetadata().getIntent() != null && hasFlag(mAmi.getPendingIntentFlags( n.getBubbleMetadata().getIntent().getTarget()), PendingIntent.FLAG_IMMUTABLE)) { throw new IllegalArgumentException(r.getKey() + " Not posted." + " PendingIntents attached to bubbles must be mutable"); - } + }*/ if (n.actions != null) { for (Notification.Action action : n.actions) { diff --git a/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java b/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java index 4697d50ed087..740505e0d3d7 100755 --- a/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java +++ b/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java @@ -7145,7 +7145,8 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { inOrder.verify(child).recordDismissalSentiment(anyInt()); } - @Test + // TODO (b/171418004): renable after app outreach + /*@Test public void testImmutableBubbleIntent() throws Exception { when(mAmi.getPendingIntentFlags(pi1)) .thenReturn(FLAG_IMMUTABLE | FLAG_ONE_SHOT); @@ -7160,7 +7161,7 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { } catch (IllegalArgumentException e) { // good } - } + }*/ @Test public void testMutableBubbleIntent() throws Exception { |