diff options
| author | 2022-02-21 14:12:33 +0000 | |
|---|---|---|
| committer | 2022-02-21 14:12:33 +0000 | |
| commit | 1d446113831e288cfbea49678326b453d064979f (patch) | |
| tree | 6a806dc9e98f72746672b8e9cfa867e3f6ef207a | |
| parent | f220fa411dbd26aa89bb7f225d69b2aa6703bf1d (diff) | |
| parent | 7dd6a1fcbefc5361b8fba526fa8b5d2255ac5824 (diff) | |
Merge "Update full charged string (1/2)" into tm-dev am: 7dd6a1fcbe
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16938504
Change-Id: Ia14e5f381902817135f5fe6a1d09a5ef1ebc364e
3 files changed, 24 insertions, 1 deletions
diff --git a/packages/SettingsLib/res/values/strings.xml b/packages/SettingsLib/res/values/strings.xml index 8965144e7351..014a033a4c01 100644 --- a/packages/SettingsLib/res/values/strings.xml +++ b/packages/SettingsLib/res/values/strings.xml @@ -1160,6 +1160,8 @@ <string name="battery_info_status_not_charging">Connected, not charging</string> <!-- Battery Info screen. Value for a status item. Used for diagnostic info screens, precise translation isn't needed --> <string name="battery_info_status_full">Charged</string> + <!-- [CHAR_LIMIT=40] Battery Info screen. Value for a status item. A state which device is fully charged --> + <string name="battery_info_status_full_charged">Fully Charged</string> <!-- Summary for settings preference disabled by administrator [CHAR LIMIT=50] --> <string name="disabled_by_admin_summary_text">Controlled by admin</string> diff --git a/packages/SettingsLib/src/com/android/settingslib/Utils.java b/packages/SettingsLib/src/com/android/settingslib/Utils.java index 4b7fb1b4698c..19114cf147e4 100644 --- a/packages/SettingsLib/src/com/android/settingslib/Utils.java +++ b/packages/SettingsLib/src/com/android/settingslib/Utils.java @@ -207,7 +207,9 @@ public class Utils { final BatteryStatus batteryStatus = new BatteryStatus(batteryChangedIntent); if (batteryStatus.isCharged()) { - statusString = res.getString(R.string.battery_info_status_full); + statusString = res.getString(compactStatus + ? R.string.battery_info_status_full_charged + : R.string.battery_info_status_full); } else { if (status == BatteryManager.BATTERY_STATUS_CHARGING) { if (compactStatus) { diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java index 4e381749b8a6..09b2a2e73c5b 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java @@ -325,6 +325,15 @@ public class UtilsTest { } @Test + public void getBatteryStatus_statusIsFullAndUseCompactStatus_returnFullyChargedString() { + final Intent intent = new Intent().putExtra(BatteryManager.EXTRA_LEVEL, 100); + final Resources resources = mContext.getResources(); + + assertThat(Utils.getBatteryStatus(mContext, intent, /* compactStatus= */ true)).isEqualTo( + resources.getString(R.string.battery_info_status_full_charged)); + } + + @Test public void getBatteryStatus_batteryLevelIs100_returnFullString() { final Intent intent = new Intent().putExtra(BatteryManager.EXTRA_STATUS, BatteryManager.BATTERY_STATUS_FULL); @@ -335,6 +344,16 @@ public class UtilsTest { } @Test + public void getBatteryStatus_batteryLevelIs100AndUseCompactStatus_returnFullyString() { + final Intent intent = new Intent().putExtra(BatteryManager.EXTRA_STATUS, + BatteryManager.BATTERY_STATUS_FULL); + final Resources resources = mContext.getResources(); + + assertThat(Utils.getBatteryStatus(mContext, intent, /* compactStatus= */ true)).isEqualTo( + resources.getString(R.string.battery_info_status_full_charged)); + } + + @Test public void getBatteryStatus_batteryLevel99_returnChargingString() { final Intent intent = new Intent(); intent.putExtra(BatteryManager.EXTRA_STATUS, BatteryManager.BATTERY_STATUS_CHARGING); |