diff options
| author | 2024-09-03 14:58:54 +0000 | |
|---|---|---|
| committer | 2024-09-03 14:58:54 +0000 | |
| commit | 1c6f875f56b1041ce834cf5d6bca4b3a1260a7da (patch) | |
| tree | a170b18596faca80a1db9438b0f718267d70a270 | |
| parent | 240f50312788701ab56a3c1f48dd94488fa7a03c (diff) | |
| parent | 6719dbdc8094257a09344934dd93f4c573b8d57b (diff) | |
Merge "Clean up fully rolled out PermissionMigrationForZeroTrustImplEnabled" into main
| -rw-r--r-- | core/java/android/app/admin/flags/flags.aconfig | 7 | ||||
| -rw-r--r-- | services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java | 36 |
2 files changed, 10 insertions, 33 deletions
diff --git a/core/java/android/app/admin/flags/flags.aconfig b/core/java/android/app/admin/flags/flags.aconfig index 5ca2dfd04c92..b99446815892 100644 --- a/core/java/android/app/admin/flags/flags.aconfig +++ b/core/java/android/app/admin/flags/flags.aconfig @@ -68,13 +68,6 @@ flag { } flag { - name: "permission_migration_for_zero_trust_impl_enabled" - namespace: "enterprise" - description: "(Implementation) Migrate existing APIs to permission based, and enable DMRH to call them to collect Zero Trust signals." - bug: "289520697" -} - -flag { name: "device_theft_api_enabled" is_exported: true namespace: "enterprise" diff --git a/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java b/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java index fb712208f513..be9cb08b23cc 100644 --- a/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java +++ b/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java @@ -16801,13 +16801,11 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub { mContext.sendBroadcastAsUser(intent, UserHandle.of(userId)); } - if (Flags.permissionMigrationForZeroTrustImplEnabled()) { - final UserHandle user = UserHandle.of(userId); - final String roleHolderPackage = getRoleHolderPackageNameOnUser( - RoleManager.ROLE_DEVICE_POLICY_MANAGEMENT, userId); - if (roleHolderPackage != null) { - broadcastExplicitIntentToPackage(intent, roleHolderPackage, user); - } + final UserHandle user = UserHandle.of(userId); + final String roleHolderPackage = getRoleHolderPackageNameOnUser( + RoleManager.ROLE_DEVICE_POLICY_MANAGEMENT, userId); + if (roleHolderPackage != null) { + broadcastExplicitIntentToPackage(intent, roleHolderPackage, user); } } }); @@ -16815,18 +16813,10 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub { @Override public SystemUpdateInfo getPendingSystemUpdate(ComponentName admin, String callerPackage) { - if (Flags.permissionMigrationForZeroTrustImplEnabled()) { - CallerIdentity caller = getCallerIdentity(admin, callerPackage); - enforcePermissions(new String[] {NOTIFY_PENDING_SYSTEM_UPDATE, - MANAGE_DEVICE_POLICY_QUERY_SYSTEM_UPDATES}, caller.getPackageName(), - caller.getUserId()); - } else { - Objects.requireNonNull(admin, "ComponentName is null"); - - final CallerIdentity caller = getCallerIdentity(admin); - Preconditions.checkCallAuthorization( - isDefaultDeviceOwner(caller) || isProfileOwner(caller)); - } + CallerIdentity caller = getCallerIdentity(admin, callerPackage); + enforcePermissions(new String[] {NOTIFY_PENDING_SYSTEM_UPDATE, + MANAGE_DEVICE_POLICY_QUERY_SYSTEM_UPDATES}, caller.getPackageName(), + caller.getUserId()); return mOwners.getSystemUpdateInfo(); } @@ -21421,13 +21411,7 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub { final CallerIdentity caller = getCallerIdentity(callerPackage); - if (Flags.permissionMigrationForZeroTrustImplEnabled()) { - enforcePermission(MANAGE_DEVICE_POLICY_CERTIFICATES, caller.getPackageName()); - } else { - Preconditions.checkCallAuthorization( - isDefaultDeviceOwner(caller) || isProfileOwner(caller) - || isCallerDelegate(caller, DELEGATION_CERT_INSTALL)); - } + enforcePermission(MANAGE_DEVICE_POLICY_CERTIFICATES, caller.getPackageName()); synchronized (getLockObject()) { final ActiveAdmin requiredAdmin = getDeviceOrProfileOwnerAdminLocked( caller.getUserId()); |