summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Varun Shah <varunshah@google.com> 2020-08-06 22:09:32 +0000
committer Varun Shah <varunshah@google.com> 2020-08-06 22:22:25 +0000
commit1c691f5bd2ac9b54c954d2009096bd774f5f4638 (patch)
treedd3a9e8e982504c5458243394e2c96be9f15ee63
parent3e2e74c1326e277b4e0a71cad7411d1027c4e403 (diff)
Don't create unnecessary objects.
Only create a new LinkedList if one doesn't exist already for the user. Bug: n/a Test: atest UsageStatsTest
-rw-r--r--services/usage/java/com/android/server/usage/UsageStatsService.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/services/usage/java/com/android/server/usage/UsageStatsService.java b/services/usage/java/com/android/server/usage/UsageStatsService.java
index 2fd6c4249f99..78556ef41edb 100644
--- a/services/usage/java/com/android/server/usage/UsageStatsService.java
+++ b/services/usage/java/com/android/server/usage/UsageStatsService.java
@@ -763,11 +763,12 @@ public class UsageStatsService extends SystemService implements
return;
}
- final LinkedList<Event> events = mReportedEvents.get(userId, new LinkedList<>());
- events.add(event);
- if (mReportedEvents.get(userId) == null) {
+ LinkedList<Event> events = mReportedEvents.get(userId);
+ if (events == null) {
+ events = new LinkedList<>();
mReportedEvents.put(userId, events);
}
+ events.add(event);
if (events.size() == 1) {
// Every time a file is persisted to disk, mReportedEvents is cleared for this user
// so trigger a flush to disk every time the first event has been added.