summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jin Seok Park <jinpark@google.com> 2019-04-19 03:16:11 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2019-04-19 03:16:11 +0000
commit1c41060583a6cb434ab7d6c0f9abe66ad5c5e089 (patch)
tree3d392ef1c4ea66e480bb45c77b650f1ed5d4c1d8
parent733379cc3a3535b26931347c0c95506bf3d1748f (diff)
parent6371ac33ddff0c4045bba3df6ea512a0eae8364a (diff)
Merge "Rename MediaSession2/MediaController2 methods" into qt-dev
-rw-r--r--api/current.txt6
-rw-r--r--media/apex/java/android/media/MediaController2.java2
-rw-r--r--media/apex/java/android/media/MediaSession2.java6
-rw-r--r--media/apex/java/android/media/MediaSession2Service.java10
4 files changed, 12 insertions, 12 deletions
diff --git a/api/current.txt b/api/current.txt
index 41adb20f5775..ab698db7fc3a 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -24656,7 +24656,7 @@ package android.media {
public class MediaController2 implements java.lang.AutoCloseable {
method public void cancelSessionCommand(@NonNull Object);
method public void close();
- method @Nullable public android.media.Session2Token getConnectedSessionToken();
+ method @Nullable public android.media.Session2Token getConnectedToken();
method public boolean isPlaybackActive();
method @NonNull public Object sendSessionCommand(@NonNull android.media.Session2Command, @Nullable android.os.Bundle);
}
@@ -25821,8 +25821,8 @@ package android.media {
method public void cancelSessionCommand(@NonNull android.media.MediaSession2.ControllerInfo, @NonNull Object);
method public void close();
method @NonNull public java.util.List<android.media.MediaSession2.ControllerInfo> getConnectedControllers();
- method @NonNull public String getSessionId();
- method @NonNull public android.media.Session2Token getSessionToken();
+ method @NonNull public String getId();
+ method @NonNull public android.media.Session2Token getToken();
method public boolean isPlaybackActive();
method @NonNull public Object sendSessionCommand(@NonNull android.media.MediaSession2.ControllerInfo, @NonNull android.media.Session2Command, @Nullable android.os.Bundle);
method public void setPlaybackActive(boolean);
diff --git a/media/apex/java/android/media/MediaController2.java b/media/apex/java/android/media/MediaController2.java
index fb4e6ac23937..9848f1a10a54 100644
--- a/media/apex/java/android/media/MediaController2.java
+++ b/media/apex/java/android/media/MediaController2.java
@@ -175,7 +175,7 @@ public class MediaController2 implements AutoCloseable {
* @return Session2Token of the connected session, or {@code null} if not connected
*/
@Nullable
- public Session2Token getConnectedSessionToken() {
+ public Session2Token getConnectedToken() {
synchronized (mLock) {
return mConnectedToken;
}
diff --git a/media/apex/java/android/media/MediaSession2.java b/media/apex/java/android/media/MediaSession2.java
index 6b56ae086a0d..0a1edb8d7712 100644
--- a/media/apex/java/android/media/MediaSession2.java
+++ b/media/apex/java/android/media/MediaSession2.java
@@ -153,7 +153,7 @@ public class MediaSession2 implements AutoCloseable {
* Returns the session ID
*/
@NonNull
- public String getSessionId() {
+ public String getId() {
return mSessionId;
}
@@ -161,7 +161,7 @@ public class MediaSession2 implements AutoCloseable {
* Returns the {@link Session2Token} for creating {@link MediaController2}.
*/
@NonNull
- public Session2Token getSessionToken() {
+ public Session2Token getToken() {
return mSessionToken;
}
@@ -553,7 +553,7 @@ public class MediaSession2 implements AutoCloseable {
try {
MediaSessionManager manager = (MediaSessionManager) mContext.getSystemService(
Context.MEDIA_SESSION_SERVICE);
- manager.notifySession2Created(session2.getSessionToken());
+ manager.notifySession2Created(session2.getToken());
} catch (Exception e) {
session2.close();
throw e;
diff --git a/media/apex/java/android/media/MediaSession2Service.java b/media/apex/java/android/media/MediaSession2Service.java
index 3f392d28fa1f..b8bf3842aae8 100644
--- a/media/apex/java/android/media/MediaSession2Service.java
+++ b/media/apex/java/android/media/MediaSession2Service.java
@@ -195,15 +195,15 @@ public abstract class MediaSession2Service extends Service {
throw new IllegalArgumentException("session is already closed");
}
synchronized (mLock) {
- MediaSession2 previousSession = mSessions.get(session.getSessionId());
+ MediaSession2 previousSession = mSessions.get(session.getId());
if (previousSession != null) {
if (previousSession != session) {
- Log.w(TAG, "Session ID should be unique, ID=" + session.getSessionId()
+ Log.w(TAG, "Session ID should be unique, ID=" + session.getId()
+ ", previous=" + previousSession + ", session=" + session);
}
return;
}
- mSessions.put(session.getSessionId(), session);
+ mSessions.put(session.getId(), session);
session.setForegroundServiceEventCallback(mForegroundServiceEventCallback);
}
}
@@ -220,11 +220,11 @@ public abstract class MediaSession2Service extends Service {
}
MediaNotification notification;
synchronized (mLock) {
- if (mSessions.get(session.getSessionId()) != session) {
+ if (mSessions.get(session.getId()) != session) {
// Session isn't added or removed already.
return;
}
- mSessions.remove(session.getSessionId());
+ mSessions.remove(session.getId());
notification = mNotifications.remove(session);
}
session.setForegroundServiceEventCallback(null);