summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Rupesh Bansal <brup@google.com> 2025-02-20 16:35:26 +0000
committer Rupesh Bansal <brup@google.com> 2025-02-21 04:47:16 -0800
commit1be91f66cb4db2d9ccf1955ea1201e8b413ef08e (patch)
tree4ed0a356a3126fe20ae523879c809a0ee240a070
parent4cd40167ba71fc07e3636285db3b8ef8bf468c06 (diff)
Fix DisplayManagerGlobalTest
A few functions needed for tests were marked package protected with VisibleForTesting annotation. However, the DisplayManagerGlobalTests is unable to access these and requires us to make them public. Many other functions in DisplayManagerGlobal already follow this pattern Bug: 391828526 Test: atest DisplayManagerGlobalTest Flag: EXEMPT test fix Change-Id: I7f66bba7e7d609ad72aed96927a0e3b7b64eaffa
-rw-r--r--core/java/android/hardware/display/DisplayManagerGlobal.java6
-rw-r--r--core/tests/coretests/src/android/hardware/display/DisplayManagerGlobalTest.java13
2 files changed, 12 insertions, 7 deletions
diff --git a/core/java/android/hardware/display/DisplayManagerGlobal.java b/core/java/android/hardware/display/DisplayManagerGlobal.java
index c4af87116eed..bebca57125b6 100644
--- a/core/java/android/hardware/display/DisplayManagerGlobal.java
+++ b/core/java/android/hardware/display/DisplayManagerGlobal.java
@@ -1499,7 +1499,7 @@ public final class DisplayManagerGlobal {
}
@VisibleForTesting
- static final class DisplayListenerDelegate {
+ public static final class DisplayListenerDelegate {
public final DisplayListener mListener;
public volatile long mInternalEventFlagsMask;
@@ -1536,7 +1536,7 @@ public final class DisplayManagerGlobal {
}
@VisibleForTesting
- boolean isEventFilterExplicit() {
+ public boolean isEventFilterExplicit() {
return mIsEventFilterExplicit;
}
@@ -1892,7 +1892,7 @@ public final class DisplayManagerGlobal {
}
@VisibleForTesting
- CopyOnWriteArrayList<DisplayListenerDelegate> getDisplayListeners() {
+ public CopyOnWriteArrayList<DisplayListenerDelegate> getDisplayListeners() {
return mDisplayListeners;
}
}
diff --git a/core/tests/coretests/src/android/hardware/display/DisplayManagerGlobalTest.java b/core/tests/coretests/src/android/hardware/display/DisplayManagerGlobalTest.java
index 8ef105f79988..de5f0ffbe23f 100644
--- a/core/tests/coretests/src/android/hardware/display/DisplayManagerGlobalTest.java
+++ b/core/tests/coretests/src/android/hardware/display/DisplayManagerGlobalTest.java
@@ -177,8 +177,10 @@ public class DisplayManagerGlobalTest {
@RequiresFlagsEnabled(Flags.FLAG_DELAY_IMPLICIT_RR_REGISTRATION_UNTIL_RR_ACCESSED)
public void test_refreshRateRegistration_implicitRRCallbacksEnabled()
throws RemoteException {
+ DisplayManager.DisplayListener displayListener1 =
+ Mockito.mock(DisplayManager.DisplayListener.class);
// Subscription without supplied events doesn't subscribe to RR events
- mDisplayManagerGlobal.registerDisplayListener(mDisplayListener, mHandler,
+ mDisplayManagerGlobal.registerDisplayListener(displayListener1, mHandler,
ALL_DISPLAY_EVENTS, /* packageName= */ null,
/* isEventFilterExplicit */ false);
Mockito.verify(mDisplayManager)
@@ -187,7 +189,9 @@ public class DisplayManagerGlobalTest {
// After registering to refresh rate changes, subscription without supplied events subscribe
// to RR events
mDisplayManagerGlobal.registerForRefreshRateChanges();
- mDisplayManagerGlobal.registerDisplayListener(mDisplayListener, mHandler,
+ DisplayManager.DisplayListener displayListener2 =
+ Mockito.mock(DisplayManager.DisplayListener.class);
+ mDisplayManagerGlobal.registerDisplayListener(displayListener2, mHandler,
ALL_DISPLAY_EVENTS, /* packageName= */ null,
/* isEventFilterExplicit */ false);
Mockito.verify(mDisplayManager)
@@ -203,7 +207,9 @@ public class DisplayManagerGlobalTest {
}
// Subscription to RR when events are supplied doesn't happen
- mDisplayManagerGlobal.registerDisplayListener(mDisplayListener, mHandler,
+ DisplayManager.DisplayListener displayListener3 =
+ Mockito.mock(DisplayManager.DisplayListener.class);
+ mDisplayManagerGlobal.registerDisplayListener(displayListener3, mHandler,
ALL_DISPLAY_EVENTS, /* packageName= */ null,
/* isEventFilterExplicit */ true);
Mockito.verify(mDisplayManager)
@@ -214,7 +220,6 @@ public class DisplayManagerGlobalTest {
int subscribedListenersCount = 0;
int nonSubscribedListenersCount = 0;
for (DisplayManagerGlobal.DisplayListenerDelegate delegate: delegates) {
-
if (delegate.isEventFilterExplicit()) {
assertEquals(ALL_DISPLAY_EVENTS, delegate.mInternalEventFlagsMask);
nonSubscribedListenersCount++;