JobScheduler: Use StringBuilder for job name generation

Improve job name generation by using StringBuilder instead of Java
string concatenation.

This change enhances readability and extensibility by using
StringBuilder for string building, makes the code easier to understand
and modify.

Bug: 354795473
Test: atest FrameworksMockingServicesTests:com.android.server.job
Test: atest CtsJobSchedulerTestCases
Flag: EXEMPT refactor
Change-Id: If7b3027918108c0508ed880f3ecdb5415b882315

1 files changed, 10 insertions, 4 deletions

diff --git a/apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java b/apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java
index 4b9d7364e27b..aaf69864fe97 100644
--- a/apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java
+++ b/apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java
@@ -673,10 +673,16 @@ public final class JobStatus {
 
         this.job = job;
 
-        final String bnNamespace = namespace == null ? "" :  "@" + namespace + "@";
-        this.batteryName = this.sourceTag != null
-                ? bnNamespace + this.sourceTag + ":" + job.getService().getPackageName()
-                : bnNamespace + job.getService().flattenToShortString();
+        StringBuilder batteryName = new StringBuilder();
+        if (namespace != null) {
+            batteryName.append("@").append(namespace).append("@");
+        }
+        if (sourceTag != null) {
+            batteryName.append(sourceTag).append(":").append(job.getService().getPackageName());
+        } else {
+            batteryName.append(job.getService().flattenToShortString());
+        }
+        this.batteryName = batteryName.toString();
 
         final String componentPackage = job.getService().getPackageName();
         mIsProxyJob = !this.sourcePackageName.equals(componentPackage);